Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

Merged
merged 3 commits into from
Jan 15, 2025
Merged

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

merged 3 commits into from
Jan 15, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 9, 2025 •
edited by padmaia
Loading

Closes PACK-3736

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 9, 2025
This was referenced Jan 9, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw mentioned this pull request Jan 9, 2025
Merged
@bgw bgw requested a review from sokra January 9, 2025 21:23
@bgw bgw marked this pull request as ready for review January 9, 2025 21:23
@ijjk
Copy link
Member

ijjk commented Jan 9, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
buildDuration 16.7s 15.1s N/A
buildDurationCached 14.2s 12s N/A
nodeModulesSize 418 MB 418 MB ✓
nextStartRea..uration (ms) 415ms 418ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
5306-HASH.js gzip 53.9 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 520 B 520 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
middleware-b..fest.js gzip 671 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 374 kB 374 kB ✓
app-page-exp..prod.js gzip 130 kB 130 kB ✓
app-page-tur..prod.js gzip 143 kB 143 kB ✓
app-page-tur..prod.js gzip 139 kB 139 kB ✓
app-page.run...dev.js gzip 362 kB 362 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.47 MB 2.47 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/return-values-should-be-non-local Change
0.pack gzip 2.1 MB 2.09 MB N/A
index.pack gzip 74.5 kB 75.8 kB ⚠️ +1.31 kB
Overall change 74.5 kB 75.8 kB ⚠️ +1.31 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: fb37366

@sokra sokra added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Jan 10, 2025 — with Graphite App
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from d2c1eab to 56c77c9 Compare January 10, 2025 21:20
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 110001f to 1f21777 Compare January 10, 2025 21:20
@ijjk
Copy link
Member

ijjk commented Jan 10, 2025 •
edited
Loading

Tests Passed

@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from 56c77c9 to 3ca36f6 Compare January 10, 2025 22:48
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 1f21777 to 1a10536 Compare January 10, 2025 22:49
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from 3ca36f6 to d930890 Compare January 10, 2025 23:11
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 1a10536 to 59ff3b4 Compare January 10, 2025 23:11
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from f8efda7 to 9c94863 Compare January 13, 2025 20:31
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from b2e9360 to 9c6d5d4 Compare January 13, 2025 20:32
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from 9c94863 to 9b82562 Compare January 13, 2025 22:09
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 9c6d5d4 to 78f1579 Compare January 13, 2025 22:10
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from 9b82562 to 006a836 Compare January 13, 2025 22:50
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 78f1579 to 073dfc1 Compare January 13, 2025 22:51
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from 006a836 to d580123 Compare January 14, 2025 02:07
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 073dfc1 to 6ed1846 Compare January 14, 2025 02:08
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch 2 times, most recently from 8ca6dfa to f6ab4a3 Compare January 14, 2025 03:02
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 6ed1846 to 40117d9 Compare January 14, 2025 03:02
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from f6ab4a3 to bff5f3b Compare January 15, 2025 06:37
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 40117d9 to 88e7b4a Compare January 15, 2025 06:37
@bgw bgw mentioned this pull request Jan 15, 2025
Merged
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch 2 times, most recently from 55f2f6c to 8283975 Compare January 15, 2025 07:23
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 88e7b4a to 18927f1 Compare January 15, 2025 07:24
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from 8283975 to dd3eb93 Compare January 15, 2025 20:17
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 18927f1 to 680675c Compare January 15, 2025 20:18
@bgw bgw force-pushed the bgw/vcarc-uses-operationvc branch from dd3eb93 to b94a9f5 Compare January 15, 2025 20:36
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 680675c to 0b8c778 Compare January 15, 2025 20:36
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 0b8c778 to 4069f47 Compare January 15, 2025 21:29
@bgw bgw changed the base branch from bgw/vcarc-uses-operationvc to canary January 15, 2025 21:29
@bgw
Move get_args back out of the macro, enforce T: Clone and do the …
b08dead 
…clone in the generic version of the function
@bgw bgw force-pushed the bgw/return-values-should-be-non-local branch from 4069f47 to b08dead Compare January 15, 2025 21:35
@bgw bgw merged commit 0031496 into canary Jan 15, 2025
131 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 15, 2025

Merge activity

  • Jan 15, 5:34 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/return-values-should-be-non-local branch January 15, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @sokra