Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make incremental and partial configurable #49

Merged
merged 4 commits into from
May 31, 2023

Conversation

Gby56
Copy link
Contributor

@Gby56 Gby56 commented Dec 14, 2022

Fixes #48 and helps with #45

@Gby56
Copy link
Contributor Author

Gby56 commented Dec 14, 2022

@tjarrettveracode I was reading the veracode docs and the partial/incremental parameters are so confusing... it sounds like it does the same thing ? If I send the whole list, plus or minus a few people everytime, it won't matter ?

In both cases it sounds that you can delete some objects if you only send 1 and forget to send the whole thing, so they clearly have a similar functionality I think ?

Note: You must set incremental=true or the command overwrites the list of users instead of adding them to the specified team.

Note: You must set partial=true or the command overwrites all existing business units.

@tjarrettveracode
Copy link
Member

@Gby56 , this is a little more complicated and I'm going to need some time to test it and review it.

@Gby56
Copy link
Contributor Author

Gby56 commented Dec 14, 2022

@tjarrettveracode In the meantime though... my change is not changing the current behavior, given the default values I pass, both are True like you hardcoded. So imo it's mostly documentation work ?

@Gby56
Copy link
Contributor Author

Gby56 commented Dec 19, 2022

@tjarrettveracode If you could merge this, it would really help out, I think it's worth making the client quite flexible on these undocumented parameters. I haven't changed the default behavior, so it's safe for the current users to keep using the client, but it lets power users use it more

@tjarrettveracode tjarrettveracode merged commit f66f516 into veracode:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for setting incremental and partial parameters
2 participants