Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for copy action #81

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add support for copy action #81

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d7607c
Add support for copy action
tomaskraina May 4, 2016
8d7f22f
Merge commit '8a05589ea367f568542a536ad0bfe7d4731ddded'
tomaskraina Sep 23, 2016
f094557
Migrate to Swift 2.3
tomaskraina Sep 23, 2016
a0ab565
Update podspec to 1.2.0
tomaskraina Sep 23, 2016
aa0c12d
Fix wrong copy selectors
tomaskraina Feb 7, 2017
ca122b6
Version bump to 1.2.0.2
tomaskraina Feb 7, 2017
3e4ed41
Migrate to Swift 3.0
tomaskraina Mar 7, 2017
272c11b
Fix crashing bug when running UI tests in Simulator with iOS 10 and a…
tomaskraina Mar 31, 2017
dafc4d2
Merge branch 'master' of github.com:venmo/Static
tomaskraina Dec 12, 2017
c7a1281
Remove workaround to avoid crash as it’s no longer needed
tomaskraina Dec 14, 2017
4605861
Use self sizing cells in example
tomaskraina Dec 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions Example/NibTableViewCell.xib
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="9060" systemVersion="15B42" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES">
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="13771" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
<device id="retina4_7" orientation="portrait">
<adaptation id="fullscreen"/>
</device>
<dependencies>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="9051"/>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="13772"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<objects>
<placeholder placeholderIdentifier="IBFilesOwner" id="-1" userLabel="File's Owner"/>
Expand All @@ -14,20 +19,19 @@
<autoresizingMask key="autoresizingMask"/>
<subviews>
<label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Custom" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="0Kr-e3-EF9">
<rect key="frame" x="130" y="41" width="60" height="21"/>
<animations/>
<rect key="frame" x="130" y="30" width="60" height="43.5"/>
<fontDescription key="fontDescription" type="system" pointSize="17"/>
<color key="textColor" cocoaTouchSystemColor="darkTextColor"/>
<nil key="highlightedColor"/>
</label>
</subviews>
<animations/>
<constraints>
<constraint firstItem="0Kr-e3-EF9" firstAttribute="centerX" secondItem="H2p-sc-9uM" secondAttribute="centerX" id="0DV-UL-ORw"/>
<constraint firstItem="0Kr-e3-EF9" firstAttribute="centerY" secondItem="H2p-sc-9uM" secondAttribute="centerY" id="Ejd-1V-inO"/>
<constraint firstAttribute="bottom" secondItem="0Kr-e3-EF9" secondAttribute="bottom" constant="30" id="KNc-V8-rli"/>
<constraint firstItem="0Kr-e3-EF9" firstAttribute="top" secondItem="H2p-sc-9uM" secondAttribute="top" constant="30" id="Lul-1i-KRr"/>
</constraints>
</tableViewCellContentView>
<animations/>
<connections>
<outlet property="centeredLabel" destination="0Kr-e3-EF9" id="BTw-PS-u6X"/>
</connections>
Expand Down
2 changes: 1 addition & 1 deletion Example/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class ViewController: TableViewController {

title = "Static"

tableView.rowHeight = 50
tableView.estimatedRowHeight = 60

// Note:
// Required to be set pre iOS11, to support autosizing
Expand Down
5 changes: 1 addition & 4 deletions Static/DataSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,7 @@ extension DataSource: UITableViewDelegate {
return row(at: indexPath)?.canCopy ?? false
}


// The parameter indexPath: IndexPath? is optinal for a purpose. See: https://openradar.appspot.com/31375101
public func tableView(_ tableView: UITableView, canPerformAction action: Selector, forRowAt indexPath: IndexPath?, withSender sender: Any?) -> Bool {
guard let indexPath = indexPath else { return false }
public func tableView(_ tableView: UITableView, canPerformAction action: Selector, forRowAt indexPath: IndexPath, withSender sender: Any?) -> Bool {
return action == #selector(UIResponder.copy(_:)) && (row(at: indexPath)?.canCopy ?? false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be tied to a specific selector case?

}

Expand Down