Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a segmented control accessory type #141

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

yeahphil
Copy link
Contributor

Here's a segmented control accessory, done in the same style as the switch accessory.

I used Static for a table that had a segmented control, and ended up going back and adding it to the library for my convenience. No problem if the idea behind this library is to stay small and not have lots of built-in accessories, but please feel free to include it!

Note that this will probably have the same behavior described in #135

Copy link
Contributor

@dmiluski dmiluski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yeahphil , thank you for taking the time to PR this.

As you aptly point out: that this will probably have the same behavior described in #135

As long as that is a known point, happy to include this if it helps your use case out. Given that this can be handled by updating a given row accessory, I think this can move forward. Letting this simmer over the weekend to see if there are any other feedback items, but I'll likely merge this in on Monday.

@yeahphil
Copy link
Contributor Author

yeahphil commented Feb 7, 2019

Hi @dmiluski, thanks for taking a look! I'm set either way but thought it might be nice to contribute this back to the project. Whether it should be merged might depend on whether you'd like a bigger set of built-in controls, or would prefer Static users add any accessories beyond the basics using the .view case.

If you think the latter makes more sense, I'd be happy to add a quick guide to making accessories to the docs when I have a few free minutes.

@dmiluski dmiluski merged commit 7ceb922 into venmo:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants