Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments-plugin): prevent false positive logging #3195

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

martijnvdbrug
Copy link
Collaborator

@martijnvdbrug martijnvdbrug commented Nov 6, 2024

Description

Errors were also logged when Mollie expired hooks are coming in. However, expired should state should be ignored.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

image
Lowest message was first

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 6, 2024 3:39pm

@martijnvdbrug
Copy link
Collaborator Author

@michaelbromley Another listen EADDRINUSE: address already in use :::3012. I guess there is are concurrency issues with detecting free ports. Maybe we can asssign each e2e its own port number? This way it will be less flaky

Copy link

sonarcloud bot commented Nov 6, 2024

@michaelbromley michaelbromley merged commit 961297d into master Nov 7, 2024
32 checks passed
@michaelbromley michaelbromley deleted the fix/mollie-duplicate-payments-logging branch November 7, 2024 13:37
@michaelbromley
Copy link
Member

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants