fix(admin-ui): Fix Variant Quick-Select Menu #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
michaelbromley
merged commit 478989e
into
vendure-ecommerce:master
29 of 30 checks passed
|
This must have regressed in recent refactoring done at the data layer. Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3143, in which the product variant quick select menu was always empty. It appears that this was because the Observable that yielded the variants that should be shown in that menu was created with
mapSingle, but it needed to be unpacked multiple times by theasyncpipe in the component template.If there is some test case that should be added for it, please let me know.
Breaking changes
Nope.
Screenshots
Here it is, working:
Checklist
📌 Always:
👍 Most of the time: