fix(core): Disallow deletion of default channel #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
michaelbromley
approved these changes
Nov 15, 2024
| @@ -370,6 +370,26 @@ describe('Channels', () => { | |||
| expect(product!.channels.map(c => c.id)).toEqual(['T_1']); | |||
| }); | |||
|
|
|||
| it('Fail to delete the default channel', async () => { | |||
There was a problem hiding this comment.
you did an e2e test, you are a good man
michaelbromley
merged commit 2ed3211
into
vendure-ecommerce:master
27 of 30 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleting the default channel breaks the entire instance since you cant log in anymore.
Fixes #3157
Breaking changes
AFAIK none.
Checklist
📌 Always:
👍 Most of the time: