Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-ui): collection product filter dark theme #3172

Merged
merged 16 commits into from
Oct 31, 2024
Merged

fix(admin-ui): collection product filter dark theme #3172

merged 16 commits into from
Oct 31, 2024

Conversation

alexisvigoureux
Copy link
Contributor

@alexisvigoureux alexisvigoureux commented Oct 29, 2024 •
edited
Loading

Description

Display text in white in dark theme on the products selection modal

Breaking changes

Screenshots

On product selection item (collection detail page)
Capture d’écran 2024-10-29 à 15 34 51

Before
Capture d’écran 2024-10-29 à 15 34 40

After
Capture d’écran 2024-10-29 à 15 34 17

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

github-actions bot and others added 11 commits October 29, 2024 14:43
@github-actions @alexisvigoureux
@toBeOfUse has signed the CLA in vendure-ecommerce#3141
02fd61e
@toBeOfUse @alexisvigoureux
docs(dev-server): fix broken link in example multi-vendor plugin read…
a78525e 
…me (vendure-ecommerce#3141)
@github-actions @alexisvigoureux
@inderjotx has signed the CLA in vendure-ecommerce#3135
b754524
@inderjotx @alexisvigoureux
docs: Fix code example (vendure-ecommerce#3135)
71abc5b 
Remove Coupon Code doesn't give ErrorResult 
it only return type of Order
@github-actions @alexisvigoureux
@d46 has signed the CLA in vendure-ecommerce#3145
f2d4583
@michaelbromley @alexisvigoureux
docs: Update getting started guide with new quick start flow
a5a07bf
@github-actions @alexisvigoureux
@gkielwasser has signed the CLA in vendure-ecommerce#3155
12a3b87
@github-actions @alexisvigoureux
@taxilian has signed the CLA in vendure-ecommerce#3151
9614292
@taxilian @alexisvigoureux
fix(admin-ui): Refund order dialog is showing the wrong field for pro…
82aeff4 
…rated unit price (vendure-ecommerce#3151)
@alexisvigoureux
fix(admin-ui): collection-filter-dark-theme
6878d29
@alexisvigoureux
fix(admin-ui): collection-filter-dark-theme
1785737
@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 29, 2024 2:51pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@alexisvigoureux
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@alexisvigoureux alexisvigoureux changed the title Fix collection filter dark theme Fix collection product filter dark theme Oct 29, 2024
@alexisvigoureux alexisvigoureux changed the title Fix collection product filter dark theme fix(admin-ui): collection product filter dark theme Oct 29, 2024
@alexisvigoureux alexisvigoureux marked this pull request as ready for review October 29, 2024 15:09
github-actions bot added a commit that referenced this pull request Oct 29, 2024
@github-actions
@alexisvigoureux has signed the CLA in #3172
fb0a274
@michaelbromley michaelbromley merged commit 55f7b71 into vendure-ecommerce:minor Oct 31, 2024
29 checks passed
@michaelbromley
Copy link
Member

Thank you for the fix! 👍

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@alexisvigoureux alexisvigoureux deleted the fix-collection-filter-dark-theme branch October 31, 2024 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexisvigoureux @michaelbromley @toBeOfUse @inderjotx @taxilian