Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Floating button for admin page #3138

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

TheValkDokk
Copy link
Contributor

Description

I added the ability to include floating action buttons in the admin UI. Admins/users can have quick access to actions on all pages, just on specific routes or based on the current user's permissions.

Usecase:

  • A user can search and view a product or variant anywhere in the admin-ui without leaving the page

Breaking changes

No

Screenshots

image

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

I'm writing test cases and update README files and will commit them soon. Right now i'm looking for your feedback about this feature and should i improve it more

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 24, 2024 6:49am

Copy link
Contributor

github-actions bot commented Oct 15, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@michaelbromley
Copy link
Member

Hi!

Thank you for taking the time to contribute. I can see you put a lot of work into this to match our existing APIs & internal patterns 👍

Regarding the feature itself, I will reference #1645 which is upcoming work in which we are refreshing the Admin UI generally.

It is possible that this feature would fit into the new designs, so we'll revisit it at that point.

@TheValkDokk
Copy link
Contributor Author

Hi!

Thank you for taking the time to contribute. I can see you put a lot of work into this to match our existing APIs & internal patterns 👍

Regarding the feature itself, I will reference #1645 which is upcoming work in which we are refreshing the Admin UI generally.

It is possible that this feature would fit into the new designs, so we'll revisit it at that point.

Is there a place where i can track this ?
Also i'm new to these mono package thing so i hope you can help me:

  • Is there a way for me to build this PR and use them in my backend ? as i don't think linking this PR to my backend is the right way.

Thanks in advance😁

@TheValkDokk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 16, 2024
@michaelbromley
Copy link
Member

Is there a way for me to build this PR and use them in my backend ? as i don't think linking this PR to my backend is the right way.

You can run npm run build from inside the /packages/admin-ui-plugin and if you change the "name" in the package.json file, to something unique e.g. "@my-org/admin-ui-plugin" (where "my-org" is whatever you like which is unique to you/your company), you should be able to publish it to npm and consume it from your app.

@TheValkDokk
Copy link
Contributor Author

TheValkDokk commented Oct 25, 2024

Is there a way for me to build this PR and use them in my backend ? as i don't think linking this PR to my backend is the right way.

You can run npm run build from inside the /packages/admin-ui-plugin and if you change the "name" in the package.json file, to something unique e.g. "@my-org/admin-ui-plugin" (where "my-org" is whatever you like which is unique to you/your company), you should be able to publish it to npm and consume it from your app.

Hi, thanks for the suggestion, i having issues where the admin-ui that i published can be download but can't import, showing error that the IDE can't find the admin-ui folder

Using vscode and navigate to the node_modules/@my-org have no sign of the admin-ui (this is also the case for @vendure) but using cli and cd to that location still show that the admin-ui does exist

Is there a config where the admin-ui package is hidden from the ide ?

Edit: my admin-ui build looks difference from yours, when viewing your admin-ui, it's shows core,dashboard,etc folders, but mine require to cd in the package folder to view those folder

Edit 2: i only build and publish admin-ui, admin-ui-plugin, ui-devkit

Copy link

sonarcloud bot commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants