fix(core): Fix test where administrator service needs to throw for in…

…valid role id

packages/core/src/config/auth/channel-role-permission-resolver-strategy.ts

@@ -28,6 +28,10 @@ export class ChannelRolePermissionResolverStrategy implements RolePermissionReso
             roleIds.length === 0
                 ? []
                 : await this.connection.getRepository(ctx, Role).findBy(roleIds.map(id => ({ id })));
+        for (const roleId of roleIds) {
+            const foundRole = roles.find(role => role.id === roleId);
+            if (!foundRole) throw new EntityNotFoundError('Role', roleId);
+        }
 
         // TODO we are relying here on the `roles` relation existing, it could be missing if you query
         // user entries without supplying the relations argument, for example:

packages/core/src/config/auth/default-role-permission-resolver-strategy.ts

@@ -1,7 +1,7 @@
 import { ID } from '@vendure/common/lib/shared-types';
 
 import { RequestContext } from '../../api';
-import { Injector } from '../../common';
+import { EntityNotFoundError, Injector } from '../../common';
 import { TransactionalConnection } from '../../connection';
 import { Role, User } from '../../entity';
 import {
@@ -27,6 +27,10 @@ export class DefaultRolePermissionResolverStrategy implements RolePermissionReso
             roleIds.length === 0
                 ? []
                 : await this.connection.getRepository(ctx, Role).findBy(roleIds.map(id => ({ id })));
+        for (const roleId of roleIds) {
+            const foundRole = roles.find(role => role.id === roleId);
+            if (!foundRole) throw new EntityNotFoundError('Role', roleId);
+        }
         // Copy so as to not mutate the original user object when setting roles
         const userCopy = new User({ ...user, roles });
         await this.connection.getRepository(ctx, User).save(userCopy, { reload: false });