Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plus character in query parameter is percent encoded #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weilikuo
Copy link
Member

Manually encodes the query parameter name and value to ensure the "+" character is percent encoded

Example result captured in Proxy (= now properly encoded to %2B)

https://[Server]/members/api/feed/?filter=authors.id:6647aacb406f410001ac6a9f%2Btype:post  [...]

@weilikuo weilikuo requested a review from zac September 19, 2024 16:20
@zac
Copy link
Member

zac commented Sep 23, 2024

@weilikuo Is there any way to opt into this encoding? I hate to complicate this too much, but having some kind of queryEncodingStrategy which we could set to .custom or something?

@zac
Copy link
Member

zac commented Sep 26, 2024

@weilikuo Here's my thinking on how to make this opt-in: #18. Happy to get feedback though if this works for our use-case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants