-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【2人目確認待ち】Tree Shaking を 3.2 に更新 #19
Open
drill-lancer
wants to merge
5
commits into
main
Choose a base branch
from
update/tree-shaking/3.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+197
−339
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ class VkCssOptimize { | |
*/ | ||
public function __construct() { | ||
add_action( 'customize_register', array( __CLASS__, 'customize_register' ) ); | ||
add_filter( 'css_tree_shaking_exclude', array( __CLASS__, 'tree_shaking_exclude' ) ); | ||
add_filter( 'css_tree_shaking_js_added_class', array( __CLASS__, 'tree_shaking_js_added_class' ) ); | ||
|
||
$options = self::get_css_optimize_options(); | ||
|
||
|
@@ -309,12 +309,6 @@ public static function get_css_optimize_options() { | |
update_option( 'vk_css_optimize_options', $vk_css_optimize_options ); | ||
} | ||
|
||
// 0.2.5 | ||
// VK Blocks 1.85 からテーブルのスクロールヒントのCSSが TreeShaking で正しく処理できず、 | ||
// その影響で非表示クラスが効かなくなるなどの不具合が発生するため、 | ||
// 見た目の不具合回避のために応急処置として強制的に TreeShaking を無効化 | ||
$vk_css_optimize_options['tree_shaking'] = ''; | ||
|
||
return $vk_css_optimize_options; | ||
} | ||
|
||
|
@@ -473,10 +467,33 @@ public static function css_tree_shaking_buffer( $buffer ) { | |
$css = $wp_filesystem->get_contents( $path_name ); | ||
} | ||
|
||
$jsaddlist = array( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @drill-lancer この $jsaddlist は何の配列ですか? |
||
'device-mobile', | ||
'header_scrolled', | ||
'active', | ||
'menu-open', | ||
'vk-mobile-nav-menu-btn', | ||
'vk-mobile-nav-open', | ||
'vk-menu-acc-active', | ||
'acc-parent-open', | ||
'acc-btn', | ||
'acc-btn-open', | ||
'acc-btn-close', | ||
'acc-child-open', | ||
'carousel-item-left', | ||
'carousel-item-next', | ||
'carousel-item-right', | ||
'carousel-item-prev', | ||
'form-control', | ||
'btn', | ||
'btn-primary', | ||
); | ||
$jsaddlist = apply_filters( 'css_tree_shaking_js_added_class', $jsaddlist ); | ||
|
||
// CSS の中身が取得できた場合のみ Tree Shaking を反映する | ||
if ( ! empty( $css ) ) { | ||
// tree shaking を実行して再格納 . | ||
$css = CSS_tree_shaking::extended_minify( CSS_tree_shaking::simple_minify( $css ), $buffer ); | ||
$css = CSS_tree_shaking::extended_minify( CSS_tree_shaking::simple_minify( $css ), $buffer, $jsaddlist ); | ||
|
||
// ファイルで読み込んでいるCSSを直接出力に置換(バージョンパラメーターあり). | ||
$buffer = str_replace( | ||
|
@@ -611,9 +628,9 @@ public static function css_preload( $tag, $handle, $href, $media ) { | |
/** | ||
* Exclude CSS. | ||
* | ||
* @param string $inidata exclude css class. | ||
* @param string $jsaddlist exclude css class. | ||
*/ | ||
public static function tree_shaking_exclude( $inidata ) { | ||
public static function tree_shaking_js_added_class( $jsaddlist ) { | ||
$options = self::get_css_optimize_options(); | ||
|
||
$exclude_classes_array = array(); | ||
|
@@ -634,8 +651,8 @@ public static function tree_shaking_exclude( $inidata ) { | |
|
||
} | ||
|
||
$inidata['class'] = array_merge( $inidata['class'], $exclude_classes_array ); | ||
$jsaddlist = array_merge( $jsaddlist, $exclude_classes_array ); | ||
|
||
return $inidata; | ||
return $jsaddlist; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drill-lancer
css_tree_shaking_exclude フィルターは Lightning などで使用されているし、いないとは思いますが使用している他の人がいる可能性もあるので削除すると影響がでるのではないかなと思います。