-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up auto for versioning/release management #566
Conversation
8986c42
to
745ed48
Compare
Publishing is handled by a 2-branch [pre-release process](https://intuit.github.io/auto/docs/generated/shipit#next-branch-default), configured in `publish.yml`. All changes should be based off the default `next` branch, and are published automatically. | ||
|
||
- PRs made into the default branch are auto-deployed to the `next` pre-release tag on NPM. The result can be installed with `npm install vega-tooltip/@next` | ||
- To release a new stable version, open a PR from `next` into `stable` using this [compare link](https://github.com/vega/vega-tooltip/compare/stable...next). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we merge the pull request? I think it would be good to document the merge strategy.
745ed48
to
1c01f50
Compare
3cd64c8
to
30d5119
Compare
@@ -13,4 +13,4 @@ jobs: | |||
with: | |||
token: ${{ secrets.GITHUB_TOKEN }} | |||
auto-merge: 'minor' | |||
merge-method: 'rebase' | |||
merge-method: 'squash' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, why do we need PAT instead of just a simple GITHUB_TOKEN (https://docs.github.com/en/actions/reference/authentication-in-a-workflow#about-the-github_token-secret)? |
a PAT would be needed if we made the base branch a protected branch (https://github.community/t/how-to-push-to-protected-branches-in-a-github-action/16101 ), which is what I assumed was happening in the tsconfig repo. However it looks like that isn't needed in this repo, so I've switched back to reading a regular GITHUB_TOKEN. |
I think I added the branch protection later. I'm happy not to have it if that simplifies the setup. |
I think there’s value in having the protected branch for high throughput
repos especially if there are multiple maintainers (auto docs recommend
protecting the pre-release branch), but it would lead to needing to set an
admin level PAT for each repo that used this protection. I defer to your
lead about what makes sense for the Vega org, I’ll just use the same
pattern as we spread this deployment config around.
…On Mon, Jul 26, 2021 at 11:46 PM Dominik Moritz ***@***.***> wrote:
I think I added the branch protection later. I'm happy not to have it if
that simplifies the setup.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#566 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE2MM2TIV467USRXJ5YR43TZYTZVANCNFSM5BBF6E5Q>
.
|
Since the release branch is just a part of next, I don't think it's too dangerous not to protect it. Let's leave it as is for now. |
Sounds good! In that case, I think this PR is good to merge. We should also switch |
We missed to update the default branch in https://github.com/vega/vega-tooltip/blob/next/.github/workflows/test.yml. Just noting so that we update it next time we make a transition. |
🚀 PR was released in |
ah - thanks for catching that!
…On Wed, Jul 28, 2021 at 12:58 PM Dominik Moritz ***@***.***> wrote:
We missed to update the default branch in
https://github.com/vega/vega-tooltip/blob/next/.github/workflows/test.yml.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#566 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE2MM5HQQOHKPDCTDZ7E6TT2AZLPANCNFSM5BBF6E5Q>
.
|
Motivation
Changes
723f22c3b9fec8705988dcba0802e6df9cbb4d82
tostable
Testing
Admin Todos
Add a github token like we have for the other repo ((not needed since we're not applying a branch protection rule, the default GITHUB_TOKEN will worksecrets.GH_PAT
)master
tonext
(let's switch this to the default branch)📦 Published PR as canary version:
0.26.1--canary.566.30d5119.0
✨ Test out this PR locally via: