Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up auto for versioning/release management #566

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Jul 27, 2021

Motivation

  • Unified versioning / release process through the Vega org:
    • less time spent spent to rebuild packages locally/releasing/managing changelogs = more time for new features

Changes

Testing

  • CI should pass

Admin Todos

  • Add a github token like we have for the other repo (secrets.GH_PAT) (not needed since we're not applying a branch protection rule, the default GITHUB_TOKEN will work
  • I've copied the current master to next (let's switch this to the default branch)
📦 Published PR as canary version: 0.26.1--canary.566.30d5119.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@hydrosquall hydrosquall self-assigned this Jul 27, 2021
@hydrosquall hydrosquall force-pushed the cameron.yick/auto-tooltip branch 4 times, most recently from 8986c42 to 745ed48 Compare July 27, 2021 01:20
Publishing is handled by a 2-branch [pre-release process](https://intuit.github.io/auto/docs/generated/shipit#next-branch-default), configured in `publish.yml`. All changes should be based off the default `next` branch, and are published automatically.

- PRs made into the default branch are auto-deployed to the `next` pre-release tag on NPM. The result can be installed with `npm install vega-tooltip/@next`
- To release a new stable version, open a PR from `next` into `stable` using this [compare link](https://github.com/vega/vega-tooltip/compare/stable...next).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we merge the pull request? I think it would be good to document the merge strategy.

@@ -13,4 +13,4 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
auto-merge: 'minor'
merge-method: 'rebase'
merge-method: 'squash'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domoritz
Copy link
Member

Just wondering, why do we need PAT instead of just a simple GITHUB_TOKEN (https://docs.github.com/en/actions/reference/authentication-in-a-workflow#about-the-github_token-secret)?

@hydrosquall
Copy link
Member Author

Just wondering, why do we need PAT instead of just a simple GITHUB_TOKEN (https://docs.github.com/en/actions/reference/authentication-in-a-workflow#about-the-github_token-secret)?

a PAT would be needed if we made the base branch a protected branch (https://github.community/t/how-to-push-to-protected-branches-in-a-github-action/16101 ), which is what I assumed was happening in the tsconfig repo. However it looks like that isn't needed in this repo, so I've switched back to reading a regular GITHUB_TOKEN.

@domoritz
Copy link
Member

I think I added the branch protection later. I'm happy not to have it if that simplifies the setup.

@hydrosquall
Copy link
Member Author

hydrosquall commented Jul 27, 2021 via email

@domoritz
Copy link
Member

Since the release branch is just a part of next, I don't think it's too dangerous not to protect it. Let's leave it as is for now.

@hydrosquall
Copy link
Member Author

Since the release branch is just a part of next, I don't think it's too dangerous not to protect it. Let's leave it as is for now.

Sounds good! In that case, I think this PR is good to merge. We should also switch next to the default branch, unless you spot anything else that should be changed/documented.

@domoritz domoritz merged commit 8d7d5cb into next Jul 28, 2021
@domoritz domoritz deleted the cameron.yick/auto-tooltip branch July 28, 2021 16:55
@domoritz
Copy link
Member

domoritz commented Jul 28, 2021

We missed to update the default branch in https://github.com/vega/vega-tooltip/blob/next/.github/workflows/test.yml. Just noting so that we update it next time we make a transition.

@github-actions
Copy link

🚀 PR was released in v0.27.0 🚀

@hydrosquall
Copy link
Member Author

hydrosquall commented Jul 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants