Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make 1D tick mark responsive to width/height #9411

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Aug 22, 2024

PR Description

See fixed example + relevant unit tests

@kanitw kanitw changed the title chore(examples): add example fix: make 1D tick mark responsive to width/height Aug 22, 2024
Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2024

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80ddac4
Status: ✅  Deploy successful!
Preview URL: https://6cde420e.vega-lite.pages.dev
Branch Preview URL: https://kw-tick-1d-height.vega-lite.pages.dev

View logs

@kanitw kanitw marked this pull request as ready for review August 22, 2024 17:00
@kanitw kanitw requested a review from a team as a code owner August 22, 2024 17:00
Copy link
Contributor

@ZacharyBys ZacharyBys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks for fixing

@kanitw kanitw merged commit c0c7b6b into main Aug 28, 2024
11 checks passed
@kanitw kanitw deleted the kw/tick-1D-height branch August 28, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants