Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude altair_saver in build.yml as Github Actions tests are not passing anymore #2893

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,29 +15,29 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Set Up Chromedriver
run: |
sudo apt-get update
sudo apt-get --only-upgrade install google-chrome-stable
sudo apt-get -yqq install chromium-chromedriver
# - name: Set Up Chromedriver
# run: |
# sudo apt-get update
# sudo apt-get --only-upgrade install google-chrome-stable
# sudo apt-get -yqq install chromium-chromedriver
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install .[dev]
pip install "selenium<4.3.0"
pip install altair_saver
# pip install "selenium<4.3.0"
# pip install altair_saver
- name: Test with pytest
run: |
pytest --doctest-modules tests
- name: Selected tests without vl-convert-python
run: |
pip uninstall vl-convert-python --yes
pytest -m save_engine --doctest-modules tests
- name: Selected tests without vl-convert-python and altair_saver
run: |
pip uninstall altair_saver --yes
pytest -m save_engine --doctest-modules tests
# - name: Selected tests without vl-convert-python
# run: |
# pip uninstall vl-convert-python --yes
# pytest -m save_engine --doctest-modules tests
# - name: Selected tests without vl-convert-python and altair_saver
# run: |
# pip uninstall altair_saver --yes
# pytest -m save_engine --doctest-modules tests
- name: Selected tests with vl-convert-python and without altair_saver
run: |
pip install vl-convert-python
# pip install vl-convert-python
pytest -m save_engine --doctest-modules tests