Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add announcement to docs #2891

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add announcement to docs #2891

merged 1 commit into from
Feb 17, 2023

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Feb 16, 2023

This PR adds an announcement to the documentation page mentioning:

This website is for Vega-Altair v5 (release candidate). Visit the Vega-Altair v4 homepage for previous release documentation.

It looks as follow.
image

I think we will need this at least temporarily.

@mattijn mattijn requested a review from joelostblom February 16, 2023 21:48
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@joelostblom joelostblom merged commit 4ed5db1 into vega:master Feb 17, 2023
@joelostblom
Copy link
Contributor

Although the tests were passing in this PR, I am seeing errors on master after merging this. They seem to be unrelated to the changes here and instead pertain to altair -saver, so maybe it was just the timing and some package like npm or similar has been updated?

@mattijn
Copy link
Contributor Author

mattijn commented Feb 18, 2023

altair_saver is broken with npm 9, see issue altair-viz/altair_saver#113 & PR altair-viz/altair_saver#116.
It seems altair_saver requires maintenance too 😞

@joelostblom
Copy link
Contributor

joelostblom commented Feb 18, 2023

Hmm yeah, maybe we can merge that in. It does look like an innocent change. But I am not familiar with node at all... But at the same time we don't want to add too much maintenance if there are a lot of fixes required to altair_saver. Maybe now that vl-convert is working well it will soon be time to deprecate altair_saver? Or at least not support new releases of altair since vl-convert is a drop-in replacement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants