[MainWindow] Repaint display bars at a reduced frequency

Too high of a frequency can't be easily read and burns up lots of CPU in redraw events.
vedderb · Jan 20, 2022 · 1b93ada · 1b93ada
1 parent d4ed932
commit 1b93ada
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/mainwindow.cpp b/mainwindow.cpp
@@ -219,6 +219,8 @@ MainWindow::MainWindow(QWidget *parent) :
     mKeyLeft = false;
     mKeyRight = false;
 
+    shouldSetDisplayBars = false;
+
     connect(mDebugTimer, SIGNAL(timeout()),
             this, SLOT(timerSlotDebugMsg()));
     connect(mTimer, SIGNAL(timeout()),
@@ -479,6 +481,7 @@ MainWindow::MainWindow(QWidget *parent) :
     mPollAppTimer.start(int(1000.0 / mSettings.value("poll_rate_app_data", 50).toDouble()));
     mPollImuTimer.start(int(1000.0 / mSettings.value("poll_rate_imu_data", 50).toDouble()));
     mPollBmsTimer.start(int(1000.0 / mSettings.value("poll_rate_bms_data", 10).toDouble()));
+    mRepaintDisplayBarTimer.start(100);
 
     connect(&mPollRtTimer, &QTimer::timeout, [this]() {
         if (ui->actionRtData->isChecked()) {
@@ -513,6 +516,15 @@ MainWindow::MainWindow(QWidget *parent) :
         }
     });
 
+    connect(&mRepaintDisplayBarTimer, &QTimer::timeout, [this]() {
+        if (shouldSetDisplayBars) {
+           ui->dispCurrent->setVal(mMcValues.current_motor);
+           ui->dispDuty->setVal(mMcValues.duty_now * 100.0);
+
+           shouldSetDisplayBars = false;
+        }
+    });
+
     // Restore size and position
     if (mSettings.contains("mainwindow/size")) {
         resize(mSettings.value("mainwindow/size").toSize());
@@ -950,8 +962,8 @@ void MainWindow::serialPortNotWritable(const QString &port)
 void MainWindow::valuesReceived(MC_VALUES values, unsigned int mask)
 {
     (void)mask;
-    ui->dispCurrent->setVal(values.current_motor);
-    ui->dispDuty->setVal(values.duty_now * 100.0);
+    mMcValues = values;
+    shouldSetDisplayBars = true;
 }
 
 void MainWindow::paramChangedDouble(QObject *src, QString name, double newParam)

diff --git a/mainwindow.h b/mainwindow.h
@@ -165,12 +165,16 @@ private slots:
     bool mKeyRight;
     bool mMcConfRead;
     bool mAppConfRead;
+    bool shouldSetDisplayBars;
     QMap<QString, int> mPageNameIdList;
 
     QTimer mPollRtTimer;
     QTimer mPollAppTimer;
     QTimer mPollImuTimer;
     QTimer mPollBmsTimer;
+    QTimer mRepaintDisplayBarTimer;
+
+    MC_VALUES mMcValues;
 
     PageWelcome *mPageWelcome;
     PageConnection *mPageConnection;