fix: 1560 Transaction.ts allows making of incomplete signed instances (…

…#1561)

packages/core/src/transaction/Transaction.ts

@@ -2,7 +2,6 @@ import * as nc_utils from '@noble/curves/abstract/utils';
 import {
     InvalidDataType,
     InvalidSecp256k1PrivateKey,
-    InvalidSecp256k1Signature,
     InvalidTransactionField,
     NotDelegatedTransaction,
     UnavailableTransactionField
@@ -474,31 +473,19 @@ class Transaction {
     }
 
     /**
-     * Creates a new Transaction instance if the provided body and optional
-     * signature are valid.
+     * Creates a new Transaction instance if the provided body is valid.
      *
      * @param {TransactionBody} body - The transaction body to be validated.
-     * @param {Uint8Array} [signature] - Optional signature to be validated.
+     * @param {Uint8Array} [signature] - Optional signature.
      * @return {Transaction} A new Transaction instance if validation is successful.
-     * @throws {InvalidSecp256k1Signature} If the provided signature is invalid.
      * @throws {InvalidTransactionField} If the provided body is invalid.
      */
     public static of(
         body: TransactionBody,
         signature?: Uint8Array
     ): Transaction {
         if (Transaction.isValidBody(body)) {
-            if (
-                signature === undefined ||
-                Transaction.isSignatureValid(body, signature)
-            ) {
-                return new Transaction(body, signature);
-            }
-            throw new InvalidSecp256k1Signature(
-                'Transaction.of',
-                'invalid signature',
-                { signature }
-            );
+            return new Transaction(body, signature);
         }
         throw new InvalidTransactionField('Transaction.of', 'invalid body', {
             fieldName: 'body',

packages/core/tests/transaction/Transaction.unit.test.ts

@@ -2,7 +2,6 @@ import { describe, expect } from '@jest/globals';
 import {
     InvalidDataType,
     InvalidSecp256k1PrivateKey,
-    InvalidSecp256k1Signature,
     InvalidTransactionField,
     NotDelegatedTransaction,
     UnavailableTransactionField
@@ -217,6 +216,30 @@ describe('Transaction class tests', () => {
                     true
                 );
             });
+
+            test('Transaction <- of delegated transactions simulating partial signed transmission between two different JS runtimes.', () => {
+                const signed = Transaction.of(
+                    TransactionFixture.delegated.body
+                ).signForDelegator(SignerFix.privateKey);
+
+                const reconstructed = Transaction.of(
+                    signed.body,
+                    signed.signature
+                );
+                expect(reconstructed.signature).toBeDefined();
+                expect(reconstructed.isDelegated).toBe(true);
+                expect(reconstructed.isSigned).toBe(false);
+
+                const signer = Address.ofPrivateKey(SignerFix.privateKey);
+                const actual = signed.signAsDelegator(
+                    signer,
+                    DelegatorFix.privateKey
+                );
+                expect(actual.isDelegated).toBe(true);
+                expect(actual.isSigned).toBe(true);
+                const expected = TransactionFixture.delegated.encodedSigned;
+                expect(actual.encoded).toEqual(expected);
+            });
         });
 
         describe('of signed transactions', () => {
@@ -305,15 +328,6 @@ describe('Transaction class tests', () => {
         });
 
         describe('Exceptions', () => {
-            test('Throw <- of invalid signature', () => {
-                expect(() =>
-                    Transaction.of(
-                        TransactionFixture.delegated.body,
-                        HexUInt.of('0xBAAAAAAD').bytes
-                    )
-                ).toThrowError(InvalidSecp256k1Signature);
-            });
-
             test('Throw <- of invalid body', () => {
                 expect(() =>
                     Transaction.of({