fix: adding dependencies per package correctly (#1513)

* fix: first commit

* fix: first commit

* fix: more changes

* fix: more changes

* fix: more changes

* fix: more changes

* fix: more changes

apps/sdk-vite-integration/src/const/index.tsx

@@ -1 +1,2 @@
+// eslint-disable-next-line react-refresh/only-export-components
 export * from './const';

eslint.config.mjs

@@ -1,12 +1,12 @@
+import { FlatCompat } from "@eslint/eslintrc";
+import js from "@eslint/js";
 import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import tsParser from "@typescript-eslint/parser";
 import localRules from "eslint-plugin-local-rules";
 import sonarjs from "eslint-plugin-sonarjs";
 import globals from "globals";
-import tsParser from "@typescript-eslint/parser";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -28,7 +28,7 @@ export default [{
     "plugin:sonarjs/recommended-legacy",
     "plugin:security/recommended-legacy",
 ), {
-    files: ["src/**/*.ts", "tests/**/*.ts"],
+    files: ["**/src/**/*.ts", "**/tests/**/*.ts"],
     plugins: {
         "@typescript-eslint": typescriptEslint,
         "local-rules": localRules,
@@ -88,6 +88,12 @@ export default [{
         "security/detect-unsafe-regex": "off",
         "security/detect-non-literal-fs-filename": "off",
         "sonarjs/sonar-no-unused-vars": "off",
-        "sonarjs/sonar-no-fallthrough": "off"
-    },
+        "sonarjs/sonar-no-fallthrough": "off",
+        "import/no-extraneous-dependencies": ["error", {"devDependencies": false, "optionalDependencies": false, "peerDependencies": false}]
+    }
+}, {
+    files: ["**/tests/**/*.ts"],
+    rules: {
+        "import/no-extraneous-dependencies": "off",
+    }
 }];

packages/aws-kms-adapter/package.json

@@ -39,6 +39,8 @@
   },
   "dependencies": {
     "@aws-sdk/client-kms": "^3.682.0",
+    "@noble/curves": "^1.6.0",
+    "@vechain/sdk-core": "1.0.0-rc.2",
     "@vechain/sdk-errors": "1.0.0-rc.2",
     "@vechain/sdk-network": "1.0.0-rc.2",
     "asn1js": "^3.0.5",

packages/aws-kms-adapter/tests/KMSVeChainSigner.solo.test.ts

@@ -64,7 +64,6 @@ describe('KMSVeChainSigner - Thor Solo', () => {
             [awsClientParameters, delegatorAwsClientParameters] = JSON.parse(
                 fs.readFileSync(awsCredentialsPath, 'utf8')
             ) as KMSClientParameters[];
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (error) {
             console.log('Loading test credentials');
             const testAwsCredentialsPath = path.resolve(

packages/aws-kms-adapter/tests/KMSVeChainSigner.testnet.test.ts

@@ -53,7 +53,6 @@ describe('KMSVeChainSigner - Testnet', () => {
             [awsClientParameters] = JSON.parse(
                 fs.readFileSync(awsCredentialsPath, 'utf8')
             ) as KMSClientParameters[];
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (error) {
             console.log('Loading test credentials');
             const testAwsCredentialsPath = path.resolve(

packages/core/package.json

@@ -39,6 +39,9 @@
   "dependencies": {
     "@ethereumjs/rlp": "^5.0.2",
     "@noble/ciphers": "^1.0.0",
+    "@noble/curves": "^1.6.0",
+    "@noble/hashes": "^1.5.0",
+    "@scure/base": "^1.1.9",
     "@scure/bip32": "^1.4.0",
     "@scure/bip39": "^1.4.0",
     "@vechain/sdk-errors": "1.0.0-rc.2",

packages/core/src/hdkey/HDKey.ts

@@ -135,7 +135,6 @@ class HDKey extends s_bip32.HDKey {
                 return s_bip32.HDKey.fromExtendedKey(
                     base58.encode(expandedPrivateKey)
                 ) as HDKey;
-                //  eslint-disable-next-line @typescript-eslint/no-unused-vars
             } catch (e) {
                 throw new InvalidSecp256k1PrivateKey(
                     'HDNode.fromPrivateKey',

packages/core/src/keystore/cryptography/ethers/keystore.ts

@@ -78,7 +78,6 @@ async function decrypt(
             stringifyData(keystore),
             password
         )) as KeystoreAccount;
-        //  eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (e) {
         throw new InvalidKeystoreParams(
             'keystore.decrypt()',

packages/core/src/keystore/cryptography/experimental/keystore.ts

@@ -560,7 +560,6 @@ function isValid(keystore: Keystore): boolean {
         ) {
             return true;
         }
-        //  eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (e) {} // Return false if parsing fails.
     return false;
 }

packages/core/src/secp256k1/Secp256k1.ts

@@ -110,7 +110,6 @@ class Secp256k1 {
     public static async generatePrivateKey(): Promise<Uint8Array> {
         try {
             return nc_secp256k1.utils.randomPrivateKey();
-            //  eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (e) {
             // Generate an ECDSA key pair
             const cryptoKey = await global.crypto.subtle.generateKey(
@@ -203,7 +202,6 @@ class Secp256k1 {
     public static randomBytes(bytesLength?: number): Uint8Array {
         try {
             return nh_randomBytes(bytesLength);
-            //  eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (e) {
             return global.crypto.getRandomValues(
                 new Uint8Array(bytesLength ?? 32)

packages/core/src/vcdm/FixedPointNumber.ts

@@ -226,7 +226,6 @@ class FixedPointNumber implements VeChainDataModel<FixedPointNumber> {
     public comparedTo(that: FixedPointNumber): null | number {
         try {
             return this.compareTo(that);
-            //  eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (e) {
             return null;
         }
@@ -955,7 +954,6 @@ class FixedPointNumber implements VeChainDataModel<FixedPointNumber> {
                 this.fractionalDigits,
                 FixedPointNumber.sqr(this.scaledValue, this.fractionalDigits)
             );
-            //  eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (e) {
             return FixedPointNumber.NaN;
         }

packages/core/src/vcdm/Hex.ts

@@ -130,7 +130,6 @@ class Hex implements VeChainDataModel<Hex> {
             // The sign is part of the IEEE 754 representation hence no need to consider `this.sign` property.
             return new DataView(this.bytes.buffer).getFloat64(0);
         }
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
         throw new InvalidOperation('Hex.n', 'not an IEEE 754 float 64 number', {
             hex: this.toString()
         });

packages/core/src/vcdm/Txt.ts

@@ -57,7 +57,6 @@ class Txt extends String implements VeChainDataModel<Txt> {
         try {
             return BigInt(this.toString());
         } catch (e) {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
             throw new InvalidOperation(
                 'Txt.bi()',
                 "Can't cast to big integer",

packages/core/src/vcdm/currency/Coin.ts

@@ -109,7 +109,6 @@ abstract class Coin implements Currency {
     isEqual(that: Currency): boolean {
         try {
             return this.compareTo(that) === 0;
-            //  eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (e) {
             return false;
         }

packages/core/tests/vcdm/hash/Blake2b256.unit.test.ts

@@ -36,7 +36,6 @@ describe('Blake2b256 class tests', () => {
     });
 
     test('Return hash for no content', () => {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         const hash = Blake2b256.of(NO_CONTENT);
         expect(hash.isEqual(NO_CONTENT_BLAKE2B256)).toBe(true);
     });

packages/core/tests/vcdm/hash/Keccak256.unit.test.ts

@@ -36,7 +36,6 @@ describe('Keccak256 class tests', () => {
     });
 
     test('Return hash for no content', () => {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         const hash = Keccak256.of(NO_CONTENT);
         expect(hash.isEqual(NO_CONTENT_KECCAK256)).toBe(true);
     });

packages/ethers-adapter/tests/adapters/factory-adapter.solo.test.ts

@@ -52,7 +52,6 @@ describe('Hardhat factory adapter tests', () => {
         const signer: Signer = new VoidSigner('0x');
 
         signer.sendTransaction = jest.fn(async (_tx) => {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-return
             return await ({} as unknown as Promise<TransactionResponse>);
         });
 

packages/ethers-adapter/tests/adapters/helpers.solo.test.ts

@@ -48,7 +48,6 @@ describe('Helpers tests', () => {
 
         provider.thorClient.transactions.waitForTransaction = jest.fn(
             async (_txID: string, _options?: WaitForTransactionOptions) => {
-                // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
                 return await Promise.resolve(null);
             }
         );

packages/hardhat-plugin/package.json

@@ -37,12 +37,13 @@
     "test:solo": "(yarn start-thor-solo && yarn test && yarn stop-thor-solo) || yarn stop-thor-solo"
   },
   "dependencies": {
+    "@nomicfoundation/hardhat-ethers": "^3.0.8",
+    "@vechain/sdk-core": "1.0.0-rc.2",
     "@vechain/sdk-errors": "1.0.0-rc.2",
     "@vechain/sdk-ethers-adapter": "1.0.0-rc.2",
+    "@vechain/sdk-logging": "1.0.0-rc.2",
     "@vechain/sdk-network": "1.0.0-rc.2",
-    "ethers": "6.13.4"
-  },
-  "devDependencies": {
-    "@nomicfoundation/hardhat-ethers": "^3.0.8"
+    "ethers": "6.13.4",
+    "hardhat": "^2.22.15"
   }
 }

packages/network/package.json

@@ -41,6 +41,7 @@
     "test:browser:solo": "(yarn start-thor-solo && yarn test:browser && yarn stop-thor-solo) || yarn stop-thor-solo"
   },
   "dependencies": {
+    "@noble/curves": "^1.6.0",
     "@vechain/sdk-core": "1.0.0-rc.2",
     "@vechain/sdk-errors": "1.0.0-rc.2",
     "@vechain/sdk-logging": "1.0.0-rc.2",

packages/network/solo-seeding/thor-solo-seeding.ts

@@ -74,6 +74,7 @@ const txBody = {
  */
 const txBodies = CLAUSES_VTHO.map((clause, index) => ({
     ...txBody,
+    // eslint-disable-next-line security/detect-object-injection
     clauses: [clause, CLAUSES_VET[index]]
 }));
 

packages/network/src/signer/signers/vechain-abstract-signer/vechain-abstract-signer.ts

@@ -297,7 +297,6 @@ abstract class VeChainAbstractSigner implements VeChainSigner {
         }
 
         // Otherwise return a random number
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-return,@typescript-eslint/no-unsafe-call,@typescript-eslint/no-unsafe-member-access
         return Hex.random(6).toString();
     }
 

packages/network/src/thor-client/contracts/model/contract.ts

@@ -64,11 +64,7 @@ class Contract<TAbi extends Abi> {
         TAbi,
         ExtractAbiFunctionNames<TAbi>
         // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-    > = {} as ContractFunctionClause<
-        TAbi,
-        ExtractAbiFunctionNames<TAbi>
-        // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-    >;
+    > = {} as ContractFunctionClause<TAbi, ExtractAbiFunctionNames<TAbi>>;
 
     public criteria: ContractFunctionCriteria<
         TAbi,

packages/network/tests/provider/providers/hardhat/hardhat-provider.solo.test.ts

@@ -329,11 +329,9 @@ describe('Hardhat provider tests', () => {
         expect(results[1].method).toBe('eth_subscription');
 
         // @ts-expect-error - Asserting that log data is present
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         expect(results[0].params.result.length).toBeGreaterThan(0);
 
         // @ts-expect-error - Asserting that log data is present
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         expect(results[1].params.result.length).toBeGreaterThan(0);
     }, 30000);
 

packages/network/tests/provider/providers/hardhat/hardhat-provider.testnet.test.ts

@@ -23,7 +23,6 @@ describe('Hardhat provider tests - testnet', () => {
      * Init thor client and provider before each test
      */
     beforeEach(() => {
-        // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
         provider = new HardhatVeChainProvider(
             new ProviderInternalBaseWallet([]),
             TESTNET_URL,

packages/network/tests/provider/providers/vechain/vechain-provider.solo.test.ts

@@ -337,11 +337,9 @@ describe('VeChain provider tests - solo', () => {
         expect(results[1].method).toBe('eth_subscription');
 
         // @ts-expect-error - Asserting that log data is present
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         expect(results[0].params.result.length).toBeGreaterThan(0);
 
         // @ts-expect-error - Asserting that log data is present
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         expect(results[1].params.result.length).toBeGreaterThan(0);
     }, 30000);
 

packages/network/tests/signer/signers/vechain-private-key-signer/vechain-private-key-signer.unit.test.ts

@@ -241,11 +241,10 @@ describe('VeChain base signer tests', () => {
             const expectedErrorString = 'not an error instance';
             jest.spyOn(Txt, 'of')
                 .mockImplementationOnce(() => {
-                    // eslint-disable-next-line @typescript-eslint/only-throw-error
                     throw expectedErrorString;
                 })
                 .mockImplementationOnce(() => {
-                    // eslint-disable-next-line @typescript-eslint/only-throw-error, sonarjs/no-throw-literal
+                    // eslint-disable-next-line sonarjs/no-throw-literal
                     throw undefined;
                 });
             await expect(
@@ -304,11 +303,10 @@ describe('VeChain base signer tests', () => {
             const expectedErrorString = 'not an error instance';
             jest.spyOn(Hex, 'of')
                 .mockImplementationOnce(() => {
-                    // eslint-disable-next-line @typescript-eslint/only-throw-error
                     throw expectedErrorString;
                 })
                 .mockImplementationOnce(() => {
-                    // eslint-disable-next-line @typescript-eslint/only-throw-error, sonarjs/no-throw-literal
+                    // eslint-disable-next-line sonarjs/no-throw-literal
                     throw undefined;
                 });
             await expect(

packages/network/tests/thor-client/contracts/contract.event.solo.test.ts

@@ -92,10 +92,9 @@ describe('ThorClient - ERC20 Contracts', () => {
             ]
         ];
 
-        expect(
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/no-unsafe-member-access
-            eventsWithArgsArray.map((x) => x.decodedData)
-        ).toEqual(expectedEvents);
+        expect(eventsWithArgsArray.map((x) => x.decodedData)).toEqual(
+            expectedEvents
+        );
 
         // listen with an args object
 
@@ -106,10 +105,9 @@ describe('ThorClient - ERC20 Contracts', () => {
             })
             .get();
 
-        expect(
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/no-unsafe-member-access
-            eventsWithAnArgsObject.map((x) => x.decodedData)
-        ).toEqual(expectedEvents);
+        expect(eventsWithAnArgsObject.map((x) => x.decodedData)).toEqual(
+            expectedEvents
+        );
     }, 10000); // Set a timeout of 10000ms for this test
 
     /**

packages/network/tests/thor-client/debug/DebugModule.solo.test.ts

@@ -237,7 +237,6 @@ describe('DebugModule testnet tests', () => {
         );
     });
 
-    // eslint-disable-next-line prettier/prettier
     describe('name = unigram, sender account index = 12', () => {
         const senderAccountIndex = 12;
         const tracerName = 'unigram';

packages/network/tests/thor-client/gas/gas.solo.test.ts

@@ -77,7 +77,6 @@ describe('ThorClient - Gas Module', () => {
                         thorSoloClient.gas.estimateGas(
                             clauses,
                             // Random address
-                            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access,@typescript-eslint/no-unsafe-argument,@typescript-eslint/no-unsafe-call
                             Hex.random(20).toString(),
                             options
                         )