Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/x allocation voting #34

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix/x allocation voting #34

merged 2 commits into from
Jan 15, 2025

Conversation

Agilulfo1820
Copy link
Member

Fix: do not allow voting multiple times for same app in single tx
Fix: generate docs script

@Agilulfo1820 Agilulfo1820 requested a review from a team as a code owner January 14, 2025 15:29
@Agilulfo1820 Agilulfo1820 changed the title Fix/x allocation voting bug Fix/x allocation voting Jan 14, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (2557822) to head (4517cd5).

Files with missing lines Patch % Lines
...vernance/modules/RoundVotesCountingUpgradeable.sol 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files          55       55           
  Lines        3530     3530           
  Branches      782      782           
=======================================
  Hits         3315     3315           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Agilulfo1820 Agilulfo1820 merged commit 7d55bd8 into main Jan 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants