fix single page mode: unnecessary rewrite from static assets to index.html
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlegolden
changed the title
index.htmlindex.html
littlegolden
changed the title
index.htmlindex.html
codfish
approved these changes
Sep 12, 2022
|
@vben-admin @anncwb why the hold up here? this is a massive bug and this seems to be a good fix, could we merge and publish? Otherwise this plugin is kind off unusable as it breaks Vite dev server static assets https://vitejs.dev/guide/assets.html#the-public-directory |
|
这么严重的bug 都不给通过是放弃治疗了嘛？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr only fix the problem that could not access static files via url directly which in Single app mode, NOT Multi Page App.
Only for reference of temporary repair.
related issues: #88, #79
BEFORE
【public & assets】
AFTER
【public & assets】