Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update USHB #378

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Update USHB #378

merged 3 commits into from
Sep 29, 2024

Conversation

sanek1000804
Copy link
Contributor

Description

Updating of USHB boundary for USHB_INF_APP use

How to prove the effect of this PR?

image
image

Is this a breaking change?

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My change or addition follow the formatting standard of the project.
  • I am on the list of approved contributors.

Copy link
Collaborator

@dirtyformal dirtyformal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I see this PR is to change the sector's name from 'Approach' to 'Information'.

What is this sector's purpose? Do they provide an Approach service (procedural or radar), or do they provide an information relay service?

If it is the latter, then this entry should be removed from the dataset.

@dirtyformal
Copy link
Collaborator

Hi @sanek1000804, could you please answer my question above?

@sanek1000804
Copy link
Contributor Author

sanek1000804 commented Sep 28, 2024

Hi @sanek1000804, could you please answer my question above?

Hello. Sorry for not answering for a long time.
There was an approach, but it was removed some time ago. So only information service remained. We decided to make its boundary because we use it at events sometimes and it covers big area with few airfields.
Answering your question, it is second option. Berezovo Information provides only information service, not approach

@dirtyformal
Copy link
Collaborator

No worries at all - thanks for your response!

In that case, it's better off if this position is removed from the dataset. Are you able to amend your PR to achieve this?

@sanek1000804
Copy link
Contributor Author

No worries at all - thanks for your response!

In that case, it's better off if this position is removed from the dataset. Are you able to amend your PR to achieve this?

Sure. Done

@dirtyformal
Copy link
Collaborator

Thanks for that! Merging now :)

@dirtyformal dirtyformal merged commit 7cb50b6 into vatsimnetwork:main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants