Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-6): switch to language based on xo5 cookie #8242

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

S3bastianCZ
Copy link
Contributor

Description

Switch to language based on xo5 cookie, If the language doesn't exist on X06, it fallback en english language

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@S3bastianCZ S3bastianCZ requested a review from J0ris-K January 13, 2025 09:36
@S3bastianCZ S3bastianCZ self-assigned this Jan 13, 2025
@S3bastianCZ S3bastianCZ requested review from MathieuRA and removed request for J0ris-K January 20, 2025 07:43
@S3bastianCZ S3bastianCZ force-pushed the language-cookie-fallback branch from f167fef to 71becea Compare January 20, 2025 10:09
@xen-orchestra/web/src/App.vue Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from J0ris-K January 20, 2025 10:14
@S3bastianCZ S3bastianCZ force-pushed the language-cookie-fallback branch from 71becea to 93f1ca2 Compare January 20, 2025 12:44
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 20, 2025 12:44
@S3bastianCZ S3bastianCZ force-pushed the language-cookie-fallback branch from 93f1ca2 to 938bcae Compare January 20, 2025 14:04
@OlivierFL
Copy link
Collaborator

Remember to look at VueUse, there may be some helpers for this.

@S3bastianCZ
Copy link
Contributor Author

Remember to look at VueUse, there may be some helpers for this.

There is indeed an integration to install for vueUse.
For now, we check the language in the cookie, do we really need vueUse for that?

@OlivierFL
Copy link
Collaborator

There is indeed an integration to install for vueUse. For now, we check the language in the cookie, do we really need vueUse for that?

Yes, the lib would provide more checks than a custom implementation, and would be useful we will handle the locales (and other things) on the settings page of XO 6.

@MathieuRA MathieuRA removed their request for review January 20, 2025 16:01
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 21, 2025 07:02
@S3bastianCZ S3bastianCZ force-pushed the language-cookie-fallback branch from 938bcae to 8c135be Compare January 21, 2025 07:45
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 22, 2025 08:43
@S3bastianCZ S3bastianCZ force-pushed the language-cookie-fallback branch from 1af3bc6 to 8152e83 Compare January 22, 2025 13:51
@MathieuRA MathieuRA merged commit 42f205e into master Jan 22, 2025
1 check passed
@MathieuRA MathieuRA deleted the language-cookie-fallback branch January 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants