Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server-backup-reports): fix undefined function in partial #8229

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Jan 8, 2025

Description

In some failure cases, backup reports were not sent because of an error during handlebars compilation.
The formatDate function was incorrectly passed from partial to partial causing the executeFunction helper to execute undefined as a function (the vmFailure helper used default formatDate=./formatDate instead of formatDate=../formatDate, the .. being necessary because of the #each loop)

XO-571

Introduced by aa9c49c

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@b-Nollet b-Nollet force-pushed the fix-undefined-backup-report branch from 51bdca7 to 68b43e7 Compare January 8, 2025 14:10
@fbeauchamp fbeauchamp merged commit cd2f74c into master Jan 8, 2025
1 check passed
@fbeauchamp fbeauchamp deleted the fix-undefined-backup-report branch January 8, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants