Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(xoa): NTP synchronization with systemd-timesyncd #8217

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Conversation

thomas-dkmt
Copy link
Contributor

Description

This PR updates the Xen Orchestra documentation to reflect the changes in NTP synchronization, as outlined in this forum discussion: XOA / XCP-ng NTP? .

Starting with recent versions of XOA, the system now uses systemd-timesyncd for time synchronization instead of ntp(d) or even chrony.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

On recent versions of Xen Orchestra, we switched to systemd-timesyncd for NTP management.
XOA documentation is updated to reflect this change.

Signed-off-by: Thomas Moraine <[email protected]>
On recent versions of Xen Orchestra, we switched to systemd-timesyncd for NTP management.
XOA documentation is updated to reflect this change.

Signed-off-by: Thomas Moraine <[email protected]>
@julien-f
Copy link
Member

julien-f commented Jan 2, 2025

The documentation is correct and useful for advanced needs, but to simply change NTP servers, one should instead use the xoa network ntp command:

$ xoa network ntp
? NTP servers (space separated)

@thomas-dkmt
Copy link
Contributor Author

The documentation is correct and useful for advanced needs, but to simply change NTP servers, one should instead use the xoa network ntp command:

$ xoa network ntp
? NTP servers (space separated)

Fixed by 46d7e9f

@thomas-dkmt thomas-dkmt changed the title (WIP) XO doc: NTP synchronization with systemd-timesyncd XO doc: NTP synchronization with systemd-timesyncd Jan 7, 2025
@julien-f julien-f self-requested a review January 8, 2025 08:03
@julien-f julien-f changed the title XO doc: NTP synchronization with systemd-timesyncd docs(xoa): NTP synchronization with systemd-timesyncd Jan 8, 2025
docs/docs/xoa.md Outdated Show resolved Hide resolved
docs/docs/xoa.md Outdated Show resolved Hide resolved
@julien-f julien-f merged commit 6d836df into master Jan 8, 2025
1 check failed
@julien-f julien-f deleted the doc-systemd branch January 8, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants