Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/VM/advanced): ability to manage xenstore entries #8174

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Dec 4, 2024

Screenshot

Capture d’écran de 2024-12-13 15-27-44
Capture d’écran de 2024-12-13 15-27-47

Description

See Zammad#26951
In order to remove an entry, simply remove the value

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA self-assigned this Dec 4, 2024
@MathieuRA MathieuRA force-pushed the edit-xenstore branch 2 times, most recently from 7a3e97c to 9722012 Compare December 4, 2024 10:10
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/xenstore-create-modal.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/xenstore-create-modal.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/xenstore-create-modal.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias December 13, 2024 14:30
@MathieuRA MathieuRA requested a review from pdonias December 19, 2024 13:47
@pdonias pdonias merged commit 8ddd7b5 into master Dec 19, 2024
1 check passed
@pdonias pdonias deleted the edit-xenstore branch December 19, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants