feat(web-core): inverse the logic of border props in MenuList.vue

vatesfr · Jan 22, 2025 · 1794251 · 1794251
1 parent 42f205e
commit 1794251
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 10 deletions.
diff --git a/@xen-orchestra/lite/src/components/account-menu/AccountMenu.vue b/@xen-orchestra/lite/src/components/account-menu/AccountMenu.vue
@@ -1,5 +1,5 @@
 <template>
-  <MenuList placement="bottom-end" border>
+  <MenuList placement="bottom-end">
     <template #trigger="{ open, isOpen }">
       <UiAccountMenuButton
         v-tooltip="isOpen ? false : { content: $t('settings'), placement: 'left' }"

diff --git a/@xen-orchestra/lite/src/components/component-story/ComponentStory.vue b/@xen-orchestra/lite/src/components/component-story/ComponentStory.vue
@@ -13,7 +13,7 @@
     </TabItem>
     <TabItem v-bind="tab(TAB.SLOTS, slotParams)">Slots</TabItem>
     <TabItem v-bind="tab(TAB.SETTINGS, settingParams)">Settings</TabItem>
-    <MenuList placement="bottom" border>
+    <MenuList placement="bottom">
       <template #trigger="{ open, isOpen }">
         <TabItem :active="isOpen" :disabled="presets === undefined" class="preset-tab" @click="open">
           <UiIcon :icon="faSliders" />

diff --git a/@xen-orchestra/lite/src/components/vm/VmHeader.vue b/@xen-orchestra/lite/src/components/vm/VmHeader.vue
@@ -2,7 +2,7 @@
   <TitleBar :icon="faDisplay">
     {{ name }}
     <template #actions>
-      <MenuList v-if="vm !== undefined" placement="bottom-end" border>
+      <MenuList v-if="vm !== undefined" placement="bottom-end">
         <template #trigger="{ open, isOpen }">
           <UiButton
             size="medium"
@@ -18,7 +18,7 @@
         </template>
         <VmActionPowerStateItems :vm-refs="[vm.$ref]" />
       </MenuList>
-      <MenuList v-if="vm !== undefined" placement="bottom-end" border>
+      <MenuList v-if="vm !== undefined" placement="bottom-end">
         <template #trigger="{ open, isOpen }">
           <UiButtonIcon
             v-tooltip="{

diff --git a/@xen-orchestra/lite/src/components/vm/VmsActionsBar.vue b/@xen-orchestra/lite/src/components/vm/VmsActionsBar.vue
@@ -2,7 +2,7 @@
   <MenuList
     :disabled="selectedRefs.length === 0"
     :horizontal="!isMobile"
-    :border="isMobile"
+    :no-border="!isMobile"
     class="vms-actions-bar"
     placement="bottom-end"
   >

diff --git a/@xen-orchestra/web-core/lib/components/menu/MenuItem.vue b/@xen-orchestra/web-core/lib/components/menu/MenuItem.vue
@@ -11,7 +11,7 @@
     >
       <slot />
     </MenuTrigger>
-    <MenuList v-else :disabled="isDisabled" border>
+    <MenuList v-else :disabled="isDisabled">
       <template #trigger="{ open, isOpen }">
         <MenuTrigger :active="isOpen" :busy="isBusy" :disabled="isDisabled" :icon @click="open">
           <slot />

diff --git a/@xen-orchestra/web-core/lib/components/menu/MenuList.vue b/@xen-orchestra/web-core/lib/components/menu/MenuList.vue
@@ -2,7 +2,13 @@
 <template>
   <slot :is-open="isOpen" :open="open" name="trigger" />
   <Teleport :disabled="!shouldTeleport" to="body">
-    <ul v-if="!hasTrigger || isOpen" ref="menu" :class="{ horizontal, border }" class="menu-list" v-bind="$attrs">
+    <ul
+      v-if="!hasTrigger || isOpen"
+      ref="menu"
+      :class="{ horizontal, border: !noBorder }"
+      class="menu-list"
+      v-bind="$attrs"
+    >
       <slot />
     </ul>
   </Teleport>
@@ -21,7 +27,7 @@ defineOptions({
 
 const props = defineProps<{
   horizontal?: boolean
-  border?: boolean
+  noBorder?: boolean
   disabled?: boolean
   placement?: Options['placement']
 }>()

diff --git a/@xen-orchestra/web-core/lib/components/table/ColumnTitle.vue b/@xen-orchestra/web-core/lib/components/table/ColumnTitle.vue
@@ -1,6 +1,6 @@
 <!-- v1.0 -->
 <template>
-  <MenuList :disabled placement="bottom-start" border>
+  <MenuList :disabled placement="bottom-start">
     <template #trigger="{ open, isOpen }">
       <th
         :class="{ interactive, disabled, focus: isOpen }"

diff --git a/@xen-orchestra/web/src/components/account-menu/AccountMenu.vue b/@xen-orchestra/web/src/components/account-menu/AccountMenu.vue
@@ -1,5 +1,5 @@
 <template>
-  <MenuList border :disabled placement="bottom-end">
+  <MenuList :disabled placement="bottom-end">
     <template #trigger="{ isOpen, open }">
       <UiAccountMenuButton
         v-tooltip="isOpen ? false : { content: $t('account-organization-more'), placement: 'bottom-end' }"