Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dynamic memory #230

Closed
wants to merge 8 commits into from
Closed

Prevent dynamic memory #230

wants to merge 8 commits into from

Conversation

hkraal
Copy link

@hkraal hkraal commented Mar 15, 2023

Seems to fix #211 but I'm unsure about possible implications.

Downgrades seem to have a chance of failing with an MEMORY_CONSTRAINT_VIOLATION_ORDER. The dynamic min/max (in the XO advanced tab) are lowered but the static max is still at the old value.

hkraal added 2 commits March 15, 2023 14:30
Dynamic memory is deprecated and shouldn't be used
@hkraal hkraal marked this pull request as draft March 15, 2023 13:49
@ddelnano
Copy link
Collaborator

Hey @hkraal, sorry for the late reply. I was on vacation this past week, but really appreciate you contributing!

My thinking is that there is likely implications as you mentioned, however, I need to spend some time looking into this before I can share any specific concerns. I should be able to give it a look by the end of this week / weekend.

@hkraal
Copy link
Author

hkraal commented Mar 22, 2023

No rush, I'm tweaking it as I go, it works correct now for me but now it should be modified to keep backwards compatibility.

I think the introduction of a "force static memory" flag could be a possible solution. Let me know your thoughts when ready and I'll take them into account.

@ddelnano
Copy link
Collaborator

I'm targeting to have time this weekend to dig in. Apologies again for the delay!

@YannickTeKulve
Copy link

YannickTeKulve commented Apr 24, 2023

Hi

Any updates on this? if you need any help would love to hear it.

@hkraal hkraal closed this by deleting the head repository Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic memory control
3 participants