Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Copyright #4212

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

nigoroll
Copy link
Member

This commit mirrors varnishcache/homepage@0f25620

as of today, each page redendered from the sphinx source contains the line

© Copyright 2010-2014, Varnish Software AS.

While this is true for some of the content, it is not for all of it and because we, several people from UPLEX, intend to contribute significant amounts of documentation in the near future, we would like to change this into something more generic, without the need to state specific copyright and authorship on each page.

@nigoroll nigoroll marked this pull request as ready for review October 11, 2024 12:51
@nigoroll nigoroll added the a=last call MR will be merged if no veto within 7 days label Oct 14, 2024
@nigoroll
Copy link
Member Author

bugwash: 1 week to raise any concerns, then it we apply the change

@huayra
Copy link

huayra commented Oct 14, 2024

@nigoroll the copyright notice on the varnish.org website cannot be compared to the documentation as such just because it is presented as a website in this case.

Our rationale has been that copyright of the documentation follows the code license, as it is distributed as a unit. The premises for this haven't changed.

@perbu
Copy link
Contributor

perbu commented Oct 15, 2024

I suspect the reason it is like it is, is because I wrote/rewrote all docs in that period so it was more or less true.

I would move the copyright statements into the RST source as comments and disregard it in the rendered pages. It really isn't that important, imo. Perhaps this would work for @nigoroll as well?

"For copyright information see the source of the document" or something like that.

@nigoroll
Copy link
Member Author

@huayra the license is clear, the question is who owns the copyright. It is clear to me that the respective authors do, so the issue here is that the rendered html says something else.

@perbu yes, thank you for your great intial work, but we have come a long way since then *)

I do not see much of an advance of "For copyright information see the source of the document" over just stating that the copyright is with the respective contributors? Or, from the other end, what is the issue with a generic statement like this?


*)

$ git ls-tree -r -z --name-only HEAD -- doc  | grep -zv phk/ | sed 's/^/.\//' | xargs -0 -n1 git blame --line-porcelain HEAD |grep -ae "^author "|sort|uniq -c|sort -nr
   7030 author Nils Goroll
   5592 author Poul-Henning Kamp
   4570 author Dridi Boukelmoune
   3767 author Geoff Simmons
   2022 author Tollef Fog Heen
   1870 author Lasse Karstensen
   1843 author Federico G. Schwindt
   1088 author Per Buer
    781 author Per Andreas Buer
    536 author Martin Blix Grydeland
    506 author Walid Boudebouda
    495 author Pål Hermunn Johansen
    362 author benc
    281 author Andrew Wiik
    174 author Andreas Plesner Jacobsen
    154 author Guillaume Quintard
     92 author Josh Soref
     71 author Jordan Christiansen
     65 author Kristian Lyngstol
     59 author Simon Stridsberg
     41 author Andreas Plesner
     18 author Dag Haavi Finstad
     14 author Kristian Lyngstøl
     14 author Asad Sajjad Ahmed
     13 author Bjoern Ruberg
     10 author Bjørn Ruberg
     10 author Alf-André Walla
      9 author Denes Matetelki
      8 author Pierre Grimaud
      6 author Thibaut Artis
      5 author madhavi.dintakurthy
      4 author Darryl Rodden
      3 author martin-uplex
      3 author Klemens Nanni
      3 author Francisco Velázquez
      3 author AlveElde
      2 author Valentin Matei
      2 author Deepjyoti Mondal
      2 author Dag Erling Smørgrav
      2 author Anders Berg
      1 author Thijs Feryn
      1 author Simon Vikstrom
      1 author Ricardo Nabinger Sanchez
      1 author Derek Hammer
      1 author Arnaud Rocher

@perbu
Copy link
Contributor

perbu commented Oct 16, 2024

@perbu yes, thank you for your great intial work, but we have come a long way since then *)

thank God.

I do not see much of an advance of "For copyright information see the source of the document" over just stating that the copyright is with the respective contributors? Or, from the other end, what is the issue with a generic statement like this?

it would provide the reader with a way of figuring out what who the respective contributors are without having 1-7 copyright statements on each rendered page. copyright is implicitly owned by the contributors, though, so stating it doesn't add much. might as well drop the copyright statement.

I no longer have a horse in this race. I was just asked to clarify what I did way back when.

@nigoroll
Copy link
Member Author

@perbu thank you for the clarification, it is much appreciated.

I would think that the wording you are proposing works similarly, except that it makes another indirection to the source. I would like to imply the meaning of "look up the contributors to determine the copyright holders". Ultimately, that could mean to state "Copyright is established through git commits". Do we want something like this?

@dridi
Copy link
Member

dridi commented Oct 17, 2024

Ultimately, that could mean to state "Copyright is established through git commits". Do we want something like this?

This is at least the purpose of the author/committer dichotomy in git. One could argue that having a single author is an unfortunate limitation, but at least when used correctly we keep track of who did what regardless of who merges contributions.

@asadsa92
Copy link
Contributor

Not relevant to the discussion about what to render on the webpage, but we could always add a MAINTAINERS & CREDITS file at the root level of the repository.

@nigoroll nigoroll added a=need bugwash and removed a=last call MR will be merged if no veto within 7 days labels Oct 17, 2024
@nigoroll nigoroll added the a=last call MR will be merged if no veto within 7 days label Oct 28, 2024
@nigoroll
Copy link
Member Author

nigoroll commented Oct 28, 2024

bugwash: give @huayra another week to clarify

@bsdphk
Copy link
Contributor

bsdphk commented Oct 28, 2024

Just for completion of narative:

The agreement between the project and V-S is that V-S would defensively hold the "collection" copyright on behalf of the project, which did/does not have a legal persona which can do so.

This is clearly stated in the first two lines of the LICENSE file:

The compilation of software known as "Varnish Cache" is distributed under the following terms:

@nigoroll
Copy link
Member Author

From my perspective, a Copyright in compilation was and still is fine, the important bit to clarify I think is that there is no transfer of copyright going on.
IIUC, the individual contributors do hold the copyright for their work, and the Copyright in compilation does not change that.

@huayra
Copy link

huayra commented Oct 28, 2024

@nigoroll yes, there's no question that contributors own their copyright. There's no copyright transfer unless otherwise explicitly agreed.

Harmonizing the copyright note with what we already have on varnish.org makes sense for the docs. And it's more precise than yet another reference to the source as contributors likely know who they are and feel likely represented by your proposal.

I just wanted to emphasize the historical context of this regarding V-S contributions and how that line specifically was a function of that and the copyright as shown in the license. I even asked @perbu to weight in just to clarify the issue and have some perspective. I'm happy we managed to discuss different aspects of this and that we are in agreement. And I apologize for making you wait,. I thought we were kind of done :)

@nigoroll
Copy link
Member Author

Thank you @huayra your clarification is much appreciated.

This commit mirrors varnishcache/homepage@0f25620

as of today, each page redendered from the sphinx source contains the line

	© Copyright 2010-2014, Varnish Software AS.

While this is true for some of the content, it is not for all of it and because
we, several people from UPLEX, intend to contribute significant amounts of
documentation in the near future, we would like to change this into something
more generic, without the need to state specific copyright and authorship on
each page.
@nigoroll nigoroll merged commit 21b155c into varnishcache:master Nov 4, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a=last call MR will be merged if no veto within 7 days a=need bugwash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants