Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all code that solely existed to support Swift 5.8 #516

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

fabianfett
Copy link
Collaborator

Land after #515.

@fabianfett fabianfett changed the title Remove all code that soly existed to support Swift 5.8 Remove all code that solely existed to support Swift 5.8 Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.24%. Comparing base (c13a11a) to head (ecdae88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   60.24%   60.24%           
=======================================
  Files         125      125           
  Lines        9191     9191           
=======================================
  Hits         5537     5537           
  Misses       3654     3654           
Files with missing lines Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 94.39% <ø> (ø)
Sources/PostgresNIO/New/NotificationListener.swift 67.53% <ø> (ø)
Sources/PostgresNIO/New/VariadicGenerics.swift 93.24% <ø> (ø)

... and 2 files with indirect coverage changes

@fabianfett fabianfett added the semver-patch No public API change. label Oct 9, 2024
@fabianfett fabianfett merged commit 225c5c4 into vapor:main Oct 9, 2024
9 checks passed
@fabianfett fabianfett deleted the ff-actually-drop-5.8 branch October 9, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants