Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up Swift Version to 5.8 #233

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Up Swift Version to 5.8 #233

merged 2 commits into from
Jul 21, 2024

Conversation

fpseverino
Copy link
Contributor

@fpseverino fpseverino commented Jul 10, 2024

These changes are now available in 4.4.0

  • Update to latest version of LeafKit to support time zones in #date tag.
  • Update to latest version of Vapor.
  • Set the minimum supported Swift version to 5.8

@fpseverino fpseverino requested review from 0xTim and gwynne as code owners July 10, 2024 12:13
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.16%. Comparing base (e7c3157) to head (f6cdbe8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   68.44%   69.16%   +0.72%     
==========================================
  Files           5        5              
  Lines         263      240      -23     
==========================================
- Hits          180      166      -14     
+ Misses         83       74       -9     

see 5 files with indirect coverage changes

@0xTim
Copy link
Member

0xTim commented Jul 10, 2024

I would say this isn't hugely needed - however you can bump the tools version to 5.8 as we should do that anyway

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim changed the title Bump Package.swift Up Swift Version to 5.8 Jul 21, 2024
@0xTim 0xTim added the semver-minor Contains new API label Jul 21, 2024
@0xTim 0xTim merged commit dd799be into vapor:main Jul 21, 2024
8 checks passed
@fpseverino fpseverino deleted the bump-package branch July 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants