Recommend Swiftly as install method on Linux #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gwynne
previously requested changes
Oct 29, 2023
docs/install/linux.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Install on Linux | |||
|
|
|||
| To use Vapor, you will need Swift 5.6 or greater. This can be installed using the toolchains available on [Swift.org](https://swift.org/download/) | |||
| To use Vapor, you will need Swift 5.6 or greater. This can be installed using the CLI tool [Swiftly](https://swift-server.github.io/swiftly/) provided by the Swift Server Workgroup (reccommended), or the toolchains available on [Swift.org](https://swift.org/download/). | |||
There was a problem hiding this comment.
Yes, thank you! I thought I knew that but wasn't able to retrieve this information, can you please point me? I have:
- corrected the Swift version.
- corrected a typo on this file
- corrected all version on the table about linux, added windows that supports Swift 5.7, as reported on swift.org and Fedora website.
docs/deploy/digital-ocean.md
Outdated
| !!! note | ||
| Swift's [Using Downloads](https://swift.org/download/#using-downloads) guide includes information on how to verify downloads using PGP signatures. | ||
| Fetching the latest stable Swift release... | ||
| Installing Swift 5.8.1 |
There was a problem hiding this comment.
The current latest release is 5.9.1, not 5.8.1
There was a problem hiding this comment.
corrected this, thanks. It was copy pasted from the Swiftly Github README file
docs/install/linux.md
Outdated
| $ swiftly install latest | ||
|
|
||
| Fetching the latest stable Swift release... | ||
| Installing Swift 5.8.1 |
0xTim
requested changes
Oct 31, 2023
docs/basics/routing.it.md
Outdated
There was a problem hiding this comment.
Can you split this out into a separate PR? Thanks!
There was a problem hiding this comment.
Of course. I did it by mistake.
There was a problem hiding this comment.
It should be ok now 👍
Closed
0xTim
requested changes
Nov 1, 2023
docs/install/linux.md
Outdated
| |Fedora|>= 35|>= 5.7| | ||
| |CentOS|7|>= 5.7| | ||
| |Amazon Linux|2|>= 5.7| | ||
| |Windows|10|>= 5.7| |
docs/install/linux.md
Outdated
|
|
||
| ## Supported Distributions and Versions | ||
|
|
||
| Vapor supports the same versions of Linux distributions that Swift 5.6 or newer versions supports. | ||
| Vapor supports the same versions of Linux distributions that Swift 5.7 or newer versions supports. |
There was a problem hiding this comment.
I think here we can tweak this to remove the note and table and just link to https://www.swift.org/platform-support/ instead
There was a problem hiding this comment.
Well, this information is doomed to be always not up to date, you're right... What about like this?
## Supported Distributions and Versions
Vapor supports the same versions of Linux distributions that Swift 5.7
or newer versions supports. Please refer to the
[official support page](https://www.swift.org/platform-support/)
in order to find updated information about which operating systems
are officially supported.
Linux distributions not officially supported may also run Swift
by compiling the source code, but Vapor cannot prove stability.
Learn more about compiling Swift from
the [Swift repo](https://github.com/apple/swift#getting-started).
9 tasks
0xTim
pushed a commit
that referenced
this pull request
Nov 7, 2023
Merged
0xTim
pushed a commit
that referenced
this pull request
Nov 23, 2023
update cn doc for PR #925 @Jinxiansen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any place we say to install Swift on Linux (deploy docs, getting started etc) should use Swiftly instead of directing people to download them from the install pages