Update routing.md #920
Update routing.md #920
Conversation
Fixes typo on docs related to 'redirect(to:type:)' being deprecated and renamed to 'redirect(to:redirectType:)'
There was a problem hiding this comment.
@KalynDavis Thanks for this! Since this is just code changes could you update the different translations as well?
docs/basics/routing.md
Outdated
| @@ -424,7 +424,7 @@ req.redirect(to: "/some/new/path") | |||
| You can also specify the type of redirect, for example to redirect a page permanently (so that your SEO is updated correctly) use: | |||
|
|
|||
| ```swift | |||
| req.redirect(to: "/some/new/path", type: .permanent) | |||
| req.redirect(to: "/some/new/path", redirectType: .permanent) | |||
| ``` | |||
|
|
|||
| The different `RedirectType`s are: | |||
There was a problem hiding this comment.
This line needs to be updated as well
| The different `RedirectType`s are: | |
| The different `Redirect`s are: |
There was a problem hiding this comment.
@0xTim shouldn't this still be RedirectType's since it is providing the different static members for redirectType?
I have updated the other translations for the original change.
There was a problem hiding this comment.
@KalynDavis RedirectType is now deprecated and the new type is Redirect so we should rename it just to avoid confusion
There was a problem hiding this comment.
@0xTim Oh, My apologies! I was under the impression that this was type->redirectType. To clarify, it is redirectType->redirect?
There was a problem hiding this comment.
Just checked the source code. I see the changes. Thanks!
There was a problem hiding this comment.
@0xTim I've updated the translations to properly reflect the changes. Thanks for pointing that out!
Note: I did notice that the German translation doesn't look to have the same formatting as the other translations. Gives me the impression the information might be outdated as well.
There was a problem hiding this comment.
The German translation is fine. 😊. Just different.
Fixes typo on
Basicsdocs section related to 'redirect(to:type:)' being deprecated and renamed to 'redirect(to:redirectType:)'