Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spanish translation for contributing.md #904

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Add Spanish translation for contributing.md #904

merged 8 commits into from
Sep 19, 2023

Conversation

alemohamad
Copy link
Member

Add Spanish translation for contributing.md

@alemohamad alemohamad added the translation-update This PR contains translations for the docs label Sep 14, 2023
@alemohamad alemohamad self-assigned this Sep 14, 2023
@alemohamad alemohamad requested a review from a team as a code owner September 14, 2023 12:19
@alemohamad alemohamad force-pushed the translation/contributing-spanish-translation branch from 57098d8 to 92d3860 Compare September 14, 2023 12:20
jacostaf10
jacostaf10 reviewed Sep 17, 2023
View reviewed changes
Copy link
Contributor

@jacostaf10 jacostaf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes, mostly for readability.

docs/contributing/contributing.es.md Outdated Show resolved Hide resolved
docs/contributing/contributing.es.md Outdated Show resolved Hide resolved
docs/contributing/contributing.es.md Outdated Show resolved Hide resolved
docs/contributing/contributing.es.md Outdated Show resolved Hide resolved
alemohamad and others added 4 commits September 17, 2023 12:25
@alemohamad @jacostaf10
Update contributing.es.md
83cf828 
Co-authored-by: Jorge Acosta <[email protected]>
@alemohamad @jacostaf10
Update contributing.es.md
19126f1 
Co-authored-by: Jorge Acosta <[email protected]>
@alemohamad @jacostaf10
Update contributing.es.md
a04a6f7 
Co-authored-by: Jorge Acosta <[email protected]>
@alemohamad @jacostaf10
Update contributing.es.md
b1cbb24 
Co-authored-by: Jorge Acosta <[email protected]>
jacostaf10
jacostaf10 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@jacostaf10 jacostaf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One word was wrongly spelled, the rest is fine.

docs/contributing/contributing.es.md Outdated Show resolved Hide resolved
@alemohamad @jacostaf10
Update contributing.es.md
2440f31 
Co-authored-by: Jorge Acosta <[email protected]>
@0xTim 0xTim enabled auto-merge (squash) September 19, 2023 12:28
@0xTim 0xTim merged commit 4882065 into vapor:main Sep 19, 2023
1 check passed
@alemohamad alemohamad deleted the translation/contributing-spanish-translation branch September 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacostaf10 jacostaf10 jacostaf10 approved these changes

@gwynne gwynne Awaiting requested review from gwynne

@0xTim 0xTim Awaiting requested review from 0xTim

Assignees

@alemohamad alemohamad

Labels
translation-update This PR contains translations for the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alemohamad @jacostaf10 @0xTim