Add Chapter Support

[Arthi-chaud]

Hello!

This PR is a contribution similar to #45, with the fixes you requested in the PR.

Regarding testing, I added chapters to the test.mp4 file and added/updated some tests.

Please let me know if something else is needed.

[vansante]

Some comments

[Arthi-chaud]

Everything's been fixed! :)

[vansante]

I have a few more nitpicks

[Arthi-chaud]

Should I do something about the lint errors? (since it's caused by the test)

Also, not sure why the test workflow fails (Tested in a dockerised environment, with the same setup as the workflow). Help would be appreciated. :)

[vansante]

The linter fails because the validateData() function is now too long(=complex), which means the best course of action is to split it up in validateStreams(), validateChapter(), etc.

As for the test failure, its fails on:

ffprobe_test.go:143: It does not have a subtitle stream.
ffprobe_test.go:149: It does not have a data stream.

The second one you adjusted in your test update, was that needed?
As for the first one, I have honestly no clue, will look into it later.

[Arthi-chaud]

I split the tests into smaller functions.

It looks like the mp4 containers' handling of chapters adds a stream which, depending on the version of ffprobe, can be interpreted as a subtitle stream (posts about it here and here)
On my machine (macOS, M1), I do not have the issue. My guess is that it is related to ffmpeg itself.

[vansante]

Let me see if I can upgrade some things (like ffprobe) to fix it.

[vansante]

Allright, I have upgraded the pipelines to run the latest release version of ffprobe, however, I did not notice any difference in tests:

#50

[vansante]

I guess I would suggest to cater the test results to what we expect on an ubuntu machine.

[Arthi-chaud]

Hi! Just rebased the fork so that it would use the updated GH actions.

Looks like the 2nd run of the test did not use the latest version of the tests. Would you mind re-running time just to check?

[vansante]

Looks good, lets merge it!

[vansante]

It was time for a new release, so here it is