make it possible to use configure with the main plugin #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
commented
Dec 9, 2023
Comment on lines
-55
to
-58
| ### Android Library (multiple variants) | ||
|
|
||
| For projects using the `com.android.library` plugin. This will publish all variants of the project (e.g. both | ||
| `debug` and `release`) or a subset of specified variants. |
There was a problem hiding this comment.
Old docs for each platform have been moved to what.md
gabrielittner
commented
Dec 9, 2023
| - [`java-platform`](#java-platform) | ||
| - [`version-catalog`](#version-catalog) | ||
|
|
||
| ## Android Library (multiple variants) |
There was a problem hiding this comment.
From here on this is a 1:1 copy of what used to be in base.md
gabrielittner
commented
Dec 9, 2023
| @@ -178,7 +178,6 @@ private fun writeSettingFile(path: Path) { | |||
| dependencyResolutionManagement { | |||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
Having this made Kotlin/JS compilation fail for some reason https://youtrack.jetbrains.com/issue/KT-61760, fortunately we don't need it.
gabrielittner
commented
Dec 9, 2023
| * Calls [configure] with a [Platform] chosen based on other applied Gradle plugins. | ||
| */ | ||
| @Incubating | ||
| fun configureBasedOnAppliedPlugins() { |
There was a problem hiding this comment.
We could allow optionally passing javadocJar: JavadocJar? = null, sourcedJar: Boolean = true (null = we use our current logic) here to eliminate many use cases of calling configure. Only weird thing about this would be that some platforms would ignore the option if it doesn't apply or is not configurable for it.
vanniktech
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings 2 changes:
configureBasedOnAppliedPlugins. This allows to get the automatic behavior for the base plugin while keeping the rest configurable manually.The tests run through without an issue, so moving the automatic KMP configuration to
afterEvaluatedoesn't seem to have any issues. In the first place I only moved it out ofafterEvaluatein #351 so that it runs before the Android configuration infinalizeDsl. That's not really needed since we can just do the KMP configuration infinalizeDslas well and then no-op inafterEvaluateif the platform was already configured.