-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web 3133 pill nav component #550
Draft
nickbergquist
wants to merge
11
commits into
main
Choose a base branch
from
web-3133-pill-nav-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbergquist
force-pushed
the
web-3133-pill-nav-component
branch
from
November 13, 2024 17:11
41e9adc
to
bcad5ab
Compare
nickbergquist
force-pushed
the
web-3133-pill-nav-component
branch
from
November 15, 2024 18:41
bcad5ab
to
ea78c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can't be merge without further related work towards the new Collections Landing page. Deploying this before then would break the current Collections Landing page, unless further work is done in the tied Tycho branch to fix the Collections Grid padding.
Ticket:
https://vandam.atlassian.net/browse/WEB-3133
Tycho PR:
https://github.com/vanda/vam-web/pull/3984