story: task data source for dashboard #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+17
to
+43
| <form | ||
| class="task-count-configuration-form" | ||
| *ngIf="{operatorItems: operatorItems$} as obs" | ||
| [formGroup]="form" | ||
| > | ||
| <div class="form__element conditions-multi-input"> | ||
| <cds-label | ||
| [helperText]="'conditionsHelperText' | widgetTranslate: dataSourceKey | async" | ||
| class="conditions-label" | ||
| >{{ 'conditions' | widgetTranslate: dataSourceKey | async }}</cds-label | ||
| > | ||
| <valtimo-carbon-multi-input | ||
| [addRowText]="'addCondition' | widgetTranslate: dataSourceKey | async" | ||
| [defaultValues]="defaultConditionValues$ | async" | ||
| [dropdownColumnTitle]="'operator' | widgetTranslate: dataSourceKey | async" | ||
| [dropdownItems]="operatorItems$ | async" | ||
| [fullWidth]="true" | ||
| [initialAmountOfRows]="0" | ||
| [keyColumnTitle]="'path' | widgetTranslate: dataSourceKey | async" | ||
| [minimumAmountOfRows]="0" | ||
| [valueColumnTitle]="'value' | widgetTranslate: dataSourceKey | async" | ||
| type="keyDropdownValue" | ||
| (allValuesValidEvent)="onAllConditionsValid($event)" | ||
| (valueChange)="conditionsValueChange($event)" | ||
| ></valtimo-carbon-multi-input> | ||
| </div> | ||
| </form> |
There was a problem hiding this comment.
Can't the form just be the wrapper instead of the div?
There was a problem hiding this comment.
This is the way the framework is set up, there some styling already available for form__element. Would rather keep it this way, since this config form might be expanded in the future
...sources/task-count/components/task-count-configuration/task-count-configuration.component.ts
Outdated
Show resolved
Hide resolved
| ConfigurationOutput<TaskCountConfiguration> | ||
| >(); | ||
|
|
||
| private _subscriptions = new Subscription(); |
There was a problem hiding this comment.
Suggested change
| private _subscriptions = new Subscription(); | |
| private readonly _subscriptions = new Subscription(); |
teodor-ritense
previously approved these changes
Dec 17, 2024
teodor-ritense
previously approved these changes
Jan 2, 2025
# Conflicts: # package-lock.json
teodor-ritense
approved these changes
Jan 2, 2025
mbritense
added a commit
that referenced
this pull request
Jan 7, 2025
* Story/129861 widget field ellipsis (#1296) * fix config for personal dashboard * 128341 Can use process variable or document property in verloop tijd in dagen field. * Add handler for array of strings (#1299) * Bugfix/130515 boolean resolver (#1300) * story/fix-fvm-updating fix form view model not updating (#1301) * #57: Configurable Documenten API Upload fields (#1298) doc: It is now possible to configure the fields that are needed when uploading to the Documenten API * doc: fix: Linking a form to a user-task without selecting the task-display-type will no longer result in an error (#1303) * Add fix for ellipsis cutting one character short (#1307) * Story/130613 reset form value (#1308) * Add form display configuration * Remove code * Add no access page for case details * Remove no access page for case details * Reset form value when submitting the start process form * fix error (#1309) * story: value selector in multi input (#1306) * refactor * abstract keyvalue to separate component * abstract singlevalue * abstract key dropdown value * abstract arbitrary amount * working value path selector in multi input * fix verzoek ui * add value path selector value * wip * small fixes * final fixes * Update projects/valtimo/components/src/lib/components/multi-input/carbon-multi-input.component.ts Co-authored-by: teodor-ritense <[email protected]> * pr comment --------- Co-authored-by: teodor-ritense <[email protected]> * Story/124923 widget resolver (#1310) * Story/fix fvm translations (#1311) * story/fix-fvm-updating fix form view model not updating * story/fix-fvm-translations fix translations * story: value path selector on dashboard widget data source config (#1312) * value path selecter dropdown * add to case counts * Update projects/valtimo/dashboard/src/lib/data-sources/case-group-by/components/case-group-by-configuration/case-group-by-configuration.component.scss Co-authored-by: teodor-ritense <[email protected]> * pr suggestion --------- Co-authored-by: teodor-ritense <[email protected]> * story: task data source for dashboard (#1305) * wip * fix fe helper text * pr comments --------- Co-authored-by: teodor-ritense <[email protected]> Co-authored-by: jarred-ritense <[email protected]> Co-authored-by: jarred-ritense <[email protected]> Co-authored-by: floris-thijssen-ritense <[email protected]> Co-authored-by: Klaas Schuijtemaker <[email protected]> Co-authored-by: Sofia <[email protected]>
mbritense
added a commit
that referenced
this pull request
Jan 8, 2025
* Story/129861 widget field ellipsis (#1296) * fix config for personal dashboard * 128341 Can use process variable or document property in verloop tijd in dagen field. * Add handler for array of strings (#1299) * Bugfix/130515 boolean resolver (#1300) * story/fix-fvm-updating fix form view model not updating (#1301) * #57: Configurable Documenten API Upload fields (#1298) doc: It is now possible to configure the fields that are needed when uploading to the Documenten API * doc: fix: Linking a form to a user-task without selecting the task-display-type will no longer result in an error (#1303) * Add fix for ellipsis cutting one character short (#1307) * Story/130613 reset form value (#1308) * Add form display configuration * Remove code * Add no access page for case details * Remove no access page for case details * Reset form value when submitting the start process form * fix error (#1309) * story: value selector in multi input (#1306) * refactor * abstract keyvalue to separate component * abstract singlevalue * abstract key dropdown value * abstract arbitrary amount * working value path selector in multi input * fix verzoek ui * add value path selector value * wip * small fixes * final fixes * Update projects/valtimo/components/src/lib/components/multi-input/carbon-multi-input.component.ts Co-authored-by: teodor-ritense <[email protected]> * pr comment --------- Co-authored-by: teodor-ritense <[email protected]> * Story/124923 widget resolver (#1310) * Story/fix fvm translations (#1311) * story/fix-fvm-updating fix form view model not updating * story/fix-fvm-translations fix translations * story: value path selector on dashboard widget data source config (#1312) * value path selecter dropdown * add to case counts * Update projects/valtimo/dashboard/src/lib/data-sources/case-group-by/components/case-group-by-configuration/case-group-by-configuration.component.scss Co-authored-by: teodor-ritense <[email protected]> * pr suggestion --------- Co-authored-by: teodor-ritense <[email protected]> * story: task data source for dashboard (#1305) * wip * fix fe helper text * pr comments * fix unlink multiple process links * fix updates on process link getting saved on other process links * fix remove process link on process link delete in modeler * restore pending changes on viewer * remove task panel feature toggle * default panel * remove console log --------- Co-authored-by: teodor-ritense <[email protected]> Co-authored-by: jarred-ritense <[email protected]> Co-authored-by: jarred-ritense <[email protected]> Co-authored-by: floris-thijssen-ritense <[email protected]> Co-authored-by: Klaas Schuijtemaker <[email protected]> Co-authored-by: Sofia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://ritense.tpondemand.com/entity/130704-befe-task-data-on-dashboards