Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valtimo issue #25: Decouple FVM from Form.io #1687

Open
wants to merge 10 commits into
base: next-minor
Choose a base branch
from

Conversation

theo-ritense
Copy link
Contributor

@theo-ritense theo-ritense commented Jan 9, 2025

Describe the changes

Link to the related Github issue: valtimo-platform/valtimo-issues#25

Relevant comments:

Breaking changes

  • The contribution only contains changes that are not breaking.

Documentation

  • Release notes have been written for these changes.

Link to the pull request in the Valtimo documentation repository:

New features or changes that have been introduced have been documented.

  • Yes
  • Not applicable

Tests

Unit tests have been added that cover these changes

  • Yes
  • Not applicable

Integration tests have been added that cover these changes

  • Yes
  • Not applicable

Security

The Secure by Default principle has been applied to these changes

  • Yes
  • Not applicable

Added or changed REST API endpoints have authentication and authorization in place

  • Yes
  • Not applicable

Valtimo access control checks have been implemented

  • Yes
  • Not applicable

Dependencies

Newly added dependencies do not introduce known vulnerabilities/CVE's and are in line with the Valtimo license

  • Yes
  • Not applicable

@theo-ritense theo-ritense marked this pull request as ready for review January 10, 2025 14:13
@theo-ritense theo-ritense requested a review from a team as a code owner January 10, 2025 14:13
@theo-ritense
Copy link
Contributor Author

@laurens-ritense is working on the required changes in valtimo-frontend-libraries. Please do not merge this PR until the FE changes are ready, or the user will be presented with a process-link option that cannot be configured yet.

@MockBean
lateinit var camundaTaskService: CamundaTaskService
// @MockBean
// lateinit var camundaTaskService: CamundaTaskService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

@@ -40,19 +43,42 @@ class TestApplication {
@TestConfiguration
class TestConfig {

// @Bean
// @ConditionalOnMissingBean(ObjectMapper::class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants