improve error message when form is not found #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
| @@ -87,7 +94,7 @@ class OnStartUpViewModelValidator( | |||
| } | |||
| } | |||
|
|
|||
| fun validateViewModel( | |||
| fun getAllMissingProperties( | |||
There was a problem hiding this comment.
Since 12.1 is already out, this is technically a breaking change.
theo-ritense
previously approved these changes
Jul 30, 2024
theo-ritense
approved these changes
Jul 30, 2024
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
…ewmodelloader-found
sirolf2009
deleted the
story/improve-error-message-when-no-viewmodelloader-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Relevant comments:
An exception is thrown without specifying what the error is about.
Since this class might log error log lines before this stacktrace, it might look like the error is related to another class
To clarify this, an exception is thrown that describes the error
Breaking changes
Documentation
New features or changes that have been introduced have been documented.
Tests
Unit tests have been added that cover these changes
Integration tests have been added that cover these changes
Security
The Secure by Default principle has been applied to these changes
Added or changed REST API endpoints have authentication and authorization in place
Valtimo access control checks have been implemented
Dependencies
Newly added dependencies do not introduce known vulnerabilities/CVE's and are in line with the Valtimo license