Use middleware #278
Use middleware #278
Conversation
| """Run service.""" | ||
|
|
||
| print_title("Trader Quickstart") | ||
| print("This script will assist you in setting up and running the Trader service.") |
There was a problem hiding this comment.
Shouldnt the Trader word be taken from the Configuration?
There was a problem hiding this comment.
Thanks for your comments @8ball030. This was an experimental PR to use the middleware in this repository, but at that time the middleware lacked some required features. For this reason, this PR is somewhat obsolete. The middleware has evolved and will be eventually integrated in this repository, most likely in a new PR.
| "description": "trader service", | ||
| "configuration": ConfigurationTemplate( | ||
| { | ||
| "rpc": "", |
There was a problem hiding this comment.
Is there a way to force for example, subgraph api key and rpc url to be necessary?
| spinner.succeed("RPC checks passed.") | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
is it possible to have a couple of flags here;
A) --dry-run: (effectively validate prior to the the deployment to verify that the deployment will proceed without issue?
B) --local-user-account-password/--no-user-password: Flag such that by default none is passed, and it will prompt the user, however if it is passed this will be used.
C) --no-wait: such that the application just fails if there is an error encountered
D) --from-env: such that the necessary vars for the service are retrieved from the environment.
reasoning.
it would then be very easy for users to automate suing ansible etc.
There was a problem hiding this comment.
Yes, we already have some of these features in main/develop branch. Will comment to the team about the rest.
| wallet, mnemonic = app.wallet_manager.create(ledger_type=LedgerType.ETHEREUM) | ||
| wallet.password = password | ||
| print() | ||
| print_box(f"Please save the mnemonic phrase for the main wallet:\n{', '.join(mnemonic)}", 0 , '-') |
There was a problem hiding this comment.
maybe a verification that the user has actually saved it?
I.e. please enter 4-9-12 from the key
Use middleware for quickstart.