Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contact-form): redesigned get contact modal #393

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

ZhmenZH
Copy link
Contributor

@ZhmenZH ZhmenZH commented Sep 21, 2023

No description provided.

@ZhmenZH ZhmenZH self-assigned this Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Visit the preview URL for this PR (updated for commit e7f96eb):

https://valor-software-site--pr393-feat-new-contact-for-hrk5a4lj.web.app

(expires Tue, 03 Oct 2023 15:17:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 62d5e57916ff939ba36fc26c8e91710f09450b38

@Alexveselun
Copy link
Contributor

Alexveselun commented Sep 22, 2023

Validations to the fields should be added:

First Name, Last Name, Company name, Your job role, Size of the company:
min: 2 symbols, (3?)
max: 50 symbols ? (я бы сделал до 30)
available: numbers, letters, dashes, underscores, spaces, single quotes
Trim spaces at the beginning and end.

It should be inaccessible that it was possible to do empty fields using space, now you can just put a space in all fields and it accepts))

Errors:
min: field is too short
max: field is too long
available: please enter valid data

Work email - need to double-check the validation for the maximum allowed characters

Comment - need to solve for the maximum value, it is good practice to do 2000 characters
min: 5
max: 2000?
available: numbers, letters, dashes, underscores, spaces, quotes

Everything else except what is in available - simply does not give the opportunity to even enter into the field

@ZhmenZH ZhmenZH force-pushed the feat/new-contact-form branch from b9664e0 to 187fd26 Compare September 26, 2023 15:02
Copy link
Contributor

@Alexveselun Alexveselun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merge to the dev env.

@ZhmenZH ZhmenZH merged commit 912288d into development Sep 27, 2023
@ZhmenZH ZhmenZH deleted the feat/new-contact-form branch September 27, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants