Enforce prettier in CI #1804
Merged
Enforce prettier in CI #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santam85
reviewed
Feb 1, 2024
.github/workflows/ci.yml
Outdated
| @@ -21,6 +21,7 @@ jobs: | |||
| node-version: 18 | |||
| - run: npm ci | |||
|
|
|||
| - run: ./node_modules/.bin/prettier --check . | |||
There was a problem hiding this comment.
Please use npx prettier . --check or npm run prettier with a custom script in package.json instead
PowerKiKi
force-pushed
the
prettier
branch
2 times, most recently
from
4fbe725 to
b8f0a86
Compare
|
CI should be passing and be ready to merge |
|
rebased |
|
Should we add a pre-commit hook as well? https://prettier.io/docs/en/install#git-hooks |
|
Good idea, done! |
gisbdzhch
pushed a commit
to gisktzh/gb3-web_ui
that referenced
this pull request
Mar 14, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ng2-charts](https://github.com/valor-software/ng2-charts) | [`^5.0.3` -> `^6.0.0`](https://renovatebot.com/diffs/npm/ng2-charts/5.0.4/6.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>valor-software/ng2-charts (ng2-charts)</summary> ### [`v6.0.0`](https://github.com/valor-software/ng2-charts/releases/tag/v6.0.0) [Compare Source](valor-software/ng2-charts@v5.0.4...v6.0.0) #### What’s Changed - BREAKING Tree shakable standalone library ([#​1801](valor-software/ng2-charts#1801)) [@​PowerKiKi](https://github.com/PowerKiKi) Users must import the library in standalone mode - BREAKING drop hardcoded and generated colors ([#​1806](valor-software/ng2-charts#1806)) [@​PowerKiKi](https://github.com/PowerKiKi) Users must migrate to the Colors [plugin](https://www.chartjs.org/docs/latest/general/colors.html) from Chart.js for color generation - Angular 17 ([#​1757](valor-software/ng2-charts#1757)) [@​santam85](https://github.com/santam85) Angular 17 is the minimum version for v6 - Target ES2022 as is done in Angular 17 new projects ([#​1802](valor-software/ng2-charts#1802)) [@​PowerKiKi](https://github.com/PowerKiKi) - Enforce prettier in CI ([#​1804](valor-software/ng2-charts#1804)) [@​PowerKiKi](https://github.com/PowerKiKi) - Drop CHANGELOG.md ([#​1805](valor-software/ng2-charts#1805)) [@​PowerKiKi](https://github.com/PowerKiKi) - Migrate to new control flow syntax ([#​1827](valor-software/ng2-charts#1827)) [@​PowerKiKi](https://github.com/PowerKiKi) - Make defaults type safe ([#​1836](valor-software/ng2-charts#1836)) [@​Cselt](https://github.com/Cselt) - chore(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.11.23 to 20.11.24 ([#​1857](valor-software/ng2-charts#1857)) [@​dependabot](https://github.com/dependabot) - chore(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.11.20 to 20.11.21 ([#̴...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged only after #1801