Target ES2022 as is done in Angular 17 new projects (#1802)

* Target ES2022 as is done in Angular 17 new projects * Centralize tsconfig To avoid duplicates and make it easier to see if we are synced with Angular default values
valor-software · Jan 31, 2024 · e67c9cc · e67c9cc
1 parent b945381
commit e67c9cc
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 61 deletions.
diff --git a/apps/ng2-charts-demo/tsconfig.json b/apps/ng2-charts-demo/tsconfig.json
@@ -1,17 +1,5 @@
 {
-  "compilerOptions": {
-    "target": "es2022",
-    "useDefineForClassFields": false,
-    "forceConsistentCasingInFileNames": true,
-    "strict": true,
-    "noImplicitOverride": true,
-    "noPropertyAccessFromIndexSignature": true,
-    "noImplicitReturns": true,
-    "noFallthroughCasesInSwitch": true,
-    "esModuleInterop": true,
-  },
-  "files": [],
-  "include": [],
+  "extends": "../../tsconfig.base.json",
   "references": [
     {
       "path": "./tsconfig.app.json"
@@ -22,12 +10,5 @@
     {
       "path": "./tsconfig.editor.json"
     }
-  ],
-  "extends": "../../tsconfig.base.json",
-  "angularCompilerOptions": {
-    "enableI18nLegacyMessageIdFormat": false,
-    "strictInjectionParameters": true,
-    "strictInputAccessModifiers": true,
-    "strictTemplates": true
-  }
+  ]
 }
diff --git a/apps/ng2-charts-demo/tsconfig.spec.json b/apps/ng2-charts-demo/tsconfig.spec.json
@@ -3,7 +3,6 @@
   "compilerOptions": {
     "outDir": "../../dist/out-tsc",
     "module": "commonjs",
-    "target": "es2016",
     "types": ["jest", "node"]
   },
   "files": ["src/test-setup.ts"],

diff --git a/libs/ng2-charts-schematics/tsconfig.json b/libs/ng2-charts-schematics/tsconfig.json
@@ -1,16 +1,8 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "module": "commonjs",
-    "forceConsistentCasingInFileNames": true,
-    "strict": true,
-    "noImplicitOverride": true,
-    "noPropertyAccessFromIndexSignature": true,
-    "noImplicitReturns": true,
-    "noFallthroughCasesInSwitch": true
+    "module": "commonjs"
   },
-  "files": [],
-  "include": [],
   "references": [
     {
       "path": "./tsconfig.lib.json"

diff --git a/libs/ng2-charts-schematics/tsconfig.lib.json b/libs/ng2-charts-schematics/tsconfig.lib.json
@@ -1,8 +1,6 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "module": "commonjs",
-    "target": "es2015",
     "outDir": "../../dist/out-tsc",
     "declaration": true,
     "types": ["node"]

diff --git a/libs/ng2-charts/tsconfig.json b/libs/ng2-charts/tsconfig.json
@@ -1,16 +1,5 @@
 {
-  "compilerOptions": {
-    "target": "es2022",
-    "useDefineForClassFields": false,
-    "forceConsistentCasingInFileNames": true,
-    "strict": true,
-    "noImplicitOverride": true,
-    "noPropertyAccessFromIndexSignature": true,
-    "noImplicitReturns": true,
-    "noFallthroughCasesInSwitch": true
-  },
-  "files": [],
-  "include": [],
+  "extends": "../../tsconfig.base.json",
   "references": [
     {
       "path": "./tsconfig.lib.json"
@@ -19,11 +8,4 @@
       "path": "./tsconfig.spec.json"
     }
   ],
-  "extends": "../../tsconfig.base.json",
-  "angularCompilerOptions": {
-    "enableI18nLegacyMessageIdFormat": false,
-    "strictInjectionParameters": true,
-    "strictInputAccessModifiers": true,
-    "strictTemplates": true
-  }
 }
diff --git a/libs/ng2-charts/tsconfig.lib.json b/libs/ng2-charts/tsconfig.lib.json
@@ -5,7 +5,6 @@
     "declaration": true,
     "declarationMap": true,
     "inlineSources": true,
-    "types": []
   },
   "exclude": [
     "src/**/*.spec.ts",

diff --git a/libs/ng2-charts/tsconfig.spec.json b/libs/ng2-charts/tsconfig.spec.json
@@ -3,7 +3,6 @@
   "compilerOptions": {
     "outDir": "../../dist/out-tsc",
     "module": "commonjs",
-    "target": "es2016",
     "types": ["jest", "node"]
   },
   "files": ["src/test-setup.ts"],

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -2,19 +2,27 @@
   "compileOnSave": false,
   "compilerOptions": {
     "rootDir": ".",
+    "forceConsistentCasingInFileNames": true,
+    "strict": true,
+    "noImplicitOverride": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "skipLibCheck": true,
+    "esModuleInterop": true,
     "sourceMap": true,
     "declaration": false,
-    "moduleResolution": "node",
-    "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
+    "moduleResolution": "node",
     "importHelpers": true,
-    "target": "es2015",
-    "module": "esnext",
+    "target": "ES2022",
+    "module": "ES2022",
+    "useDefineForClassFields": false,
+    "emitDecoratorMetadata": true,
     "lib": [
-      "es2020",
+      "ES2022",
       "dom"
     ],
-    "skipLibCheck": true,
     "skipDefaultLibCheck": true,
     "baseUrl": ".",
     "paths": {
@@ -29,5 +37,11 @@
   "exclude": [
     "node_modules",
     "tmp"
-  ]
+  ],
+  "angularCompilerOptions": {
+    "enableI18nLegacyMessageIdFormat": false,
+    "strictInjectionParameters": true,
+    "strictInputAccessModifiers": true,
+    "strictTemplates": true
+  }
 }