Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move from npm to pnpm #2400

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

build: move from npm to pnpm #2400

wants to merge 4 commits into from

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented May 10, 2024 •
edited
Loading

This pr changes the package manager used from npm to pnpm along with on CI
also closes #2123

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@WikiRik
Copy link
Member

WikiRik commented May 10, 2024

How would this close the associated issue? The peer dependency versions are still conflicting until we update rollup

@rubiin
Copy link
Member Author

rubiin commented May 10, 2024 •
edited
Loading

About that , pnpm doesnt have that peer dep issue when you run pnpm install. I am hoping to update the deps too but the browser stuff is failing

@WikiRik
Copy link
Member

WikiRik commented Jun 5, 2024

Let's revisit this after we've merged #2401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Issue: Installation via npm fails
2 participants
@rubiin @WikiRik