-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Readme, Docstrings datasets and small additions notebook #39
Conversation
The import formatting in my pre-commit setup seems to be off, I'll need to fix that on Monday... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes or discussion required. Appreciated all the work.
It is probably because you added a docstring at the beginning of the files and most likely ruff or isort are complaining.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import formatting in my pre-commit setup seems to be off, I'll need to fix that on Monday...
It is probably because you added a docstring at the beginning of the files and most likely ruff or isort are complaining.
In any case i'll fix it in my branch so don't bother too much. Just check that you are running black>=24
and run:
ruff .
pre-commit run --all-files
Seems to be some issue with isort. I'll leave it for now. pre-commit checks out locally for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the help Stephan!
Additional fixes: