Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Packaging #3

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Better Packaging #3

merged 1 commit into from
Sep 25, 2023

Conversation

shenoynikhil
Copy link
Collaborator

@shenoynikhil shenoynikhil commented Sep 25, 2023

What is this about?

Based on python packaging guidelines and not being able to import openQDC outside the repo, moved the package under src/ directory.
Changes,

  • Moved the openqdc/ directory under src/ directory
  • Modified pyproject.toml to ensure it picks the package from src/

Reference Link:

Checklist:

  • Was this PR discussed in a issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added or an existing one is deleted.

@shenoynikhil shenoynikhil requested a review from prtos as a code owner September 25, 2023 18:06
@shenoynikhil shenoynikhil merged commit 56834ee into main Sep 25, 2023
@shenoynikhil shenoynikhil deleted the package-changes branch September 25, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant