Fix regression: radio buttons now enable/disable corect column again

vaeth · Jan 26, 2018 · 7113f91 · 7113f91
1 parent 0d93fcb
commit 7113f91
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,5 +1,11 @@
 # ChangeLog for squashmount
 
+*bookmarkdupes-5.2:
+	Martin Väth <martin at mvath.de>:
+	- Fix regression from 5.1: radio buttons in expert mode now enable/
+	  disable correct columns again. Thanks to perdolka for reporting:
+	  https://github.com/vaeth/bookmarkdupes/issues/56
+
 *bookmarkdupes-5.1:
 	Martin Väth <martin at mvath.de>:
 	- Change layout of "expert mode" table slightly, see

diff --git a/data/tab/dupes.js b/data/tab/dupes.js
@@ -343,10 +343,10 @@ function changeRule(id) {
   const children = row.children;
   children[4].firstChild.disabled = off;
   children[5].firstChild.disabled = off;
-  children[6].firstChild.disabled = off;
   children[7].firstChild.disabled = off;
-  children[8].firstChild.disabled = filterOrOff;
-  children[9].firstChild.disabled = filterOrOff;
+  children[8].firstChild.disabled = off;
+  children[10].firstChild.disabled = filterOrOff;
+  children[11].firstChild.disabled = filterOrOff;
 }
 
 function addButtonsRulesLocal(restore, clean) {

diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
   "short_name": "bookmarkdupes",
   "description": "__MSG_extensionDescription__",
   "author": "Martin Väth",
-  "version": "5.1",
+  "version": "5.2",
   "manifest_version": 2,
   "homepage_url": "https://addons.mozilla.org/en-US/firefox/addon/bookmark-dupes/",
   "default_locale": "en",