Update useInput() to include name in key
#674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some key values (e.g. 'insert', 'home', 'end') were basically lost. In these cases, the `input` value would be an empty string and the generated `key` data would contain no additional information about the value. To resolve this, directly include `keypress.name` in the generated `key` data so this information is not lost.
|
Check if any types / docs needs to be updated. |
Update the `Key` type in src/hooks/use-input.ts to include the new `name` field. Update `useInput()` documentation for theh `inputHandler()` callback to include a description of the new `key.name`.
OK. I've update:
|
For cases where `parseKeypress()` does not provide `keypress.name` *and* `input` is not empty, set `keypress.name` to `input`.
|
I wonder if it would be better to instead expose a It's kinda weird to mix one letter presses like We could then even strongly type the property with the supported names: |
sindresorhus
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some key values (e.g. 'insert', 'home', 'end') were basically lost. In these cases, the
inputvalue would be an empty string and the generatedkeydata would contain no additional information about the value.To resolve this, directly include
keypress.namein the generatedkeydata so this information is not lost.