Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use simpler CI detection #638

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Use simpler CI detection #638

merged 1 commit into from
Nov 11, 2023

Conversation

sindresorhus
Copy link
Collaborator

The is-ci package attempts to detect every CI service, which is unsustainable. It also has a higher risk of false-positives. For example, it detects the environment variable RUN_ID as CI-specific, although other services could use it. Constant updates for new CIs create version fragmentation, resulting in inconsistent behavior across dependent packages. Pushing for CI services to use a standardized CI environment variable is a more robust solution.

Feel free to close if you disagree. Just a suggestion.

sindresorhus
sindresorhus commented Nov 9, 2023
View reviewed changes
src/ink.tsx
@@ -16,7 +16,6 @@ import logUpdate, {type LogUpdate} from './log-update.js';
import instances from './instances.js';
import App from './components/App.js';

const isCi = process.env['CI'] === 'false' ? false : originalIsCi;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is-in-ci already has this check

@vadimdemedes
Copy link
Owner

👍

@vadimdemedes vadimdemedes merged commit fd0698b into master Nov 11, 2023
4 checks passed
@vadimdemedes vadimdemedes deleted the simpler-ci branch November 11, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindresorhus @vadimdemedes